[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch: newmenu
From:       Simon Hausmann <sh () caldera ! de>
Date:       2000-08-16 17:20:09
[Download RAW message or body]



On Wed, 16 Aug 2000, David Faure wrote:

> On Wed, 16 Aug 2000, Simon Hausmann wrote :
> 
> >>Hi,
> >
> >The attached patch allows to undo operations from the new menu. I
> >personally consider it to be a bugfix. What do others think?
> 
> Yes, very good idea.
> 
> Note: this doesn't solve it all, since for .desktop files (like
> Application and Mimetype), it's the properties dialog that does
> the copying - so that it comes up with the values of the template
> but without creating the destination file yet (*).
> Well, it's in kfile so I doubt we can do anything there.... or we have to
> add a DCOP call, or to put the undo manager in kio. Hmm. Not good.

Hmmm, I don't have the API in my mind right now, but can't we make the
PropsDlg emit a signal with the job attached or so. Then the popupmenu can
connect to it and do the undo notification.

Ah, I guess the popupmenu is already destroyed then.

Hmm!

We definitely need a reference to the job :-(

> Oh, or maybe we can connect to the dialog's signal (when it's completed)
> and record the undo operation at that point.
> 
> (*) : reason: if you copy a .desktop application template and THEN edit
> it, it's too late, it's the old values that are taken into account by ksycoca
> (k menu etc).... and it makes cancel easier as well.
> 
> Well, commit this one, as a good start ;-)

Done :)

Bye,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]