[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Bug#5417: Javascript bug?
From:       Lars Knoll <Lars.Knoll () mpi-hd ! mpg ! de>
Date:       2000-06-23 11:08:56
[Download RAW message or body]

Looks ok to me. 

Lars


On Fri, 23 Jun 2000, Harri Porten wrote:

> Chris Colohan wrote:
> > 
> > If you go to the web site:
> > 
> > http://www.montrealjazzfest.com
> > 
> > and click on "ENGLISH (fast)", nothing happens.  A new window with the
> > non-flash version of the site is supposed to open up.
> 
> Is it be okay to add the following code to KHTMLPart::urlSelected() ?
> 
> --- khtml_part.cpp      2000/06/22 19:09:52     1.163
> +++ khtml_part.cpp      2000/06/23 10:29:10
> @@ -1375,6 +1375,13 @@
>    else
>        hasTarget = true;
>  
> +  static QString javascript = QString::fromLatin1("javascript:");
> +  if ( url.left(11) == javascript )
> +  {
> +    executeScript( url.right( url.length() - 11) );
> +    return;
> +  }
> +
>    KURL cURL = completeURL( url );
>  
>    kdDebug( 6000 ) << "complete URL:" << cURL.url() << " target = " <<
> target << endl;
> 
> Not that I used QString url directly. I dislike exceptions for any
> protocol like the next guy but I'm not sure if KURL could be used as it
> might garble the JS code after the protocol name.
> 
> Harri.
> 

-- 
Lars Knoll                                 knoll@mpi-hd.mpg.de
  PGP pub key [6DADF3D5]: finger knoll@pluto.mpi-hd.mpg.de 

[prev in list] [next in list] [prev in thread] [next in thread]