[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug#3571: No HTML title on app title bar
From:       Lars Knoll <lars () trolltech ! com>
Date:       2000-05-16 16:37:12
[Download RAW message or body]



On Tue, 16 May 2000, David Faure wrote:

> On Tue, May 16, 2000 at 05:05:47PM +0200, Lars Knoll wrote:
> > 
> > 
> > On Tue, 16 May 2000, David Faure wrote:
> > 
> > > On Mon, May 15, 2000 at 09:31:36PM -0600, The Mighty Mike Master wrote:
> > > > Package: konqueror
> > > > Version: 1.9.2 (KDE 1.90 Beta >= 20000511)
> > > > Severity: normal
> > > > 
> > > > I consider it pretty normal to display the title of the current HTML
> > > > document on the application's title bar. Konqueror does not do this.
> > > 
> > > Indeed... :(
> > > I tried to have a look, but I'm stumped in khtml's code (though very clean,
> > > the overall structure still escapes me :)
> > > 
> > > Some debug output shows:
> > > konqueror: KHTMLParser::getElement for ID_TITLE
> > > konqueror: HTMLTitleElementImpl::HTMLTitleElementImpl
> > > konqueror: htmltokenizer tagID == ID_TITLE
> > > konqueror: htmltokenizer tagID == ID_TITLE
> > > 
> > > but void HTMLTitleElementImpl::close() is never called
> > > (that's the one that emits the signal setWindowCaption).
> > > Apparently it's some old stuff not used anymore.
> > > (Or is it a bug and close should be called ?)
> > > Shouldn't this be part of the rendering anyway ?
> > 
> > And I thought it was still a bug in konqueror ;-)
> 
> Hihi ! I did a good thing, to look at it then ;-)
> Otherwise it could have lasted for a full year :/

Probably... ;-)

> > The old khtml version called close() on the DOM elements, the new one
> > doesn't do that anymore.
> OK, guessed so :)
> 
> > But as title is in the document head, it doesn't
> > get corresponding rendering objects neither. I think we'll have to move
> > the code to the document and check for the title when the head is closed
> > (which the parser tells the document).
> Where would that be ?
> Oh, I guess I should rather let you do that instead of me breaking khtml ;-)

Fixed.

> > > Related remark: 'bool title' in htmltokenizer.* seems unused, right ?
> > 
> > Looks like ;-)
> That's the worst for 3rd-party contributors ;-)

Don't want to make their life too easy.... ;-)
Fixed too.

Lars

[prev in list] [next in list] [prev in thread] [next in thread]