[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: find in KHTML
From:       Daniel Naber <dnaber () mini ! gt ! owl ! de>
Date:       2000-04-25 20:51:05
[Download RAW message or body]

On Die, 25 Apr 2000, you wrote:

> +       d->m_findNode = next;

> Should work now.

Thanks, that's better. I still get a crash in the "no match" case. This seems 
to fix it:

--- khtml_part.cpp.org  Tue Apr 25 22:46:20 2000
+++ khtml_part.cpp      Tue Apr 25 22:46:31 2000
@@ -897,7 +897,9 @@
        if(!next) next = d->m_findNode->nextSibling();
        while(d->m_findNode && !next) {
            d->m_findNode = d->m_findNode->parentNode();
-           next = d->m_findNode->nextSibling();
+           if( d->m_findNode ) {
+                   next = d->m_findNode->nextSibling();
+            }
        }
        d->m_findNode = next;
        if(!d->m_findNode) return false;

The code looks like it wants to jump to the place where the match occured, 
but it does'nt yet (x, y always == 0). I guess it would be difficult for the 
application to do that, so it will hopefully be implemented?

Regards
 Daniel

[prev in list] [next in list] [prev in thread] [next in thread]