[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kdeinit
From:       Simon Hausmann <shaus () helios ! med ! Uni-Magdeburg ! DE>
Date:       2000-04-05 12:14:47
[Download RAW message or body]

On Wed, 5 Apr 2000, David Faure wrote:

> On Wed, Apr 05, 2000 at 01:29:56PM +0200, Simon Hausmann wrote:
> > 
> > 
> > On Wed, 5 Apr 2000, David Faure wrote:
> > 
> > > On Wed, Apr 05, 2000 at 01:05:37PM +0200, Simon Hausmann wrote:
> > > > 
> > > > 1) Add a second konqueror.desktop (different name) , with
> > > > Exec=libkonqueror
> > > > 
> > > > 2) Hack kinit to also look for appname.la and libappname.la when trying to
> > > >    dlopen the service.
> > > 
> > > 3) Define a konqueror.so which includes main and links to libkonqueror.so
> > 
> > That is what I tried, too, and I get:
> > automake: konqueror/Makefile.am: `konqueror.la' is not a standard libtool
> > library name
> > make: *** [Makefile.in] Error 1
> > 
> > This seems to be related to the fact that we have libkonqueror.la and
> > konqueror.la, which libtool doesn't seem to like.
> 
> You mean it works if you rename (temporarily) libkonqueror.so to
> something else ? That would be strange...

Well, I don't understand it myself :-)

I attached the Makefile.am .

automake processes the makefile only if I rm'ed konqueror and
libkonqueror* . The make seems to build the stuff and in the end libtool
aborts with:

libtool: link: libtool library `konqueror.la' must begin with `lib'
Try `libtool --help --mode=link' for more information.
make[1]: *** [konqueror.la] Error 1

/me clueless :-)

> > Another possible solution: Move the code which is current in libkonqueror
> > to libkonq and get rid of libkonqueror. (that way we can create
> > konqueror.la I think)
> > 
> > (it seems...well..strange to me anyway to have libkonq and libkonqueror
> > :-))
> 
> Well... libkonq is for stuff needed by various other apps, it's in fact
> the "file manager construction kit" and I would have called it
> libkfm if name thing didn't exist before for something else.
> Or libkfile, already taken too ;-)
> Should we go for libfmck (see long name above) ? People will be quick
> to replace the m with another letter ;-)

hehh

> libkonqueror is the stuff that is used to all konqueror views, right ?
> (at least the builtin ones). That's the one we could rename
> (say to libkonqcore or libkonqgui)
> 
> and konqueror.so is just a kdeinit trick, we have to stick to that name.
> 
> But right, this shows we use shared libs for too many things now ;-)
> 
> In any case, we certainly don't want to merge libkonq and libkonqueror.
> Take kicker, for instance. It simply needs the properties dialog
> (which needs KonqFileItem). We surely don't want kicker to link
> to ALL the konqueror code (including the mainview, childview, all that stuff)
> just for that. Same for kfind, etc.
> The "file manager construction kit" concept makes sense. The name of its lib not :-)

BTW, libkonqueror does not contain the mainview, childview code. It only
contains the shared stuff, like the Konqueror KInstance, the background
dialog for the iconview and the props stuff. (well, see yourself :-)

I can see your concerns of "bloating" libkonq with konqueror-specific
stuff, and I also agree that libkonq is a good name for the file
management "kit", but OTOH IMHO libkonqueror (the current one) does not
contain any heavy/huge code (which would require lots of relocations,
etc.) .

Anyway, you decide :-) . I don't really care if we keep libkonqueror or
not. I'm mostly interested in getting konqueror.la, for a faster startup.


Ciao,
 Simon

["Makefile.am" (TEXT/PLAIN)]


INCLUDES = -I$(top_srcdir)/libkonq -I$(top_srcdir)/kcontrol/input $(all_includes)

SUBDIRS = . plugins kfmexec client iconview dirtree listview pics

lib_LTLIBRARIES = libkonqueror.la konqueror.la

rcdir = $(kde_datadir)/konqueror
rc_DATA = konqueror.rc

kdelnkdir = $(kde_servicesdir)
kdelnk_DATA = konqueror.desktop

servicetypedir = $(kde_servicetypesdir)
servicetype_DATA = konq_plugin.desktop konq_metaview.desktop

METASOURCES = AUTO

include_HEADERS = KonquerorIface.h

libkonqueror_la_SOURCES = \
			  konq_propsview.cc konq_propsmainview.cc konq_htmlsettings.cc \
			  konq_events.cc \
			  konq_bgnddlg.cc \
		          konq_factory.cc
#			  konq_metadata.cc

libkonqueror_la_LDFLAGS = $(all_libraries) -version-info 1:0:0 -module -no-undefined

libkonqueror_la_LIBADD = ../libkonq/libkonq.la -lkparts

bin_PROGRAMS = konqueror

konqueror_la_SOURCES = konq_main.cc KonquerorIface.skel konq_mainview.skel \
		    konq_mainview.cc \
		    konq_run.cc konq_childview.cc konq_viewmgr.cc \
                    konq_misc.cc \
		    konq_frame.cc \
		    konq_actions.cc \
		    konq_profiledlg.cc

konqueror_la_LDFLAGS = $(KDE_RPATH) $(all_libraries)
konqueror_la_LIBDADD = libkonqueror.la $(LIB_KIMGIO)

konqueror_SOURCES = dummy.cc
konqueror_LDFLAGS = $(KDE_RPATH) $(all_libraries)
konqueror_LDADD = konqueror.la

dummy.cc:
	echo > dummy.cc

messages: rc.cpp
	$(EXTRACTRC) */*.rc >> rc.cpp
	$(XGETTEXT) -kaliasLocal -o $(podir)/konqueror.pot rc.cpp *.h *.cc *view/*h *view/*cc

check_PROGRAMS = linktest
#using $(konqueror_SOURCES) below doesn't work (am_edit)
linktest_SOURCES = konq_main.cc KonquerorIface.skel konq_mainview.skel \
                   konq_mainview.cc \
                   konq_run.cc konq_childview.cc konq_viewmgr.cc \
                   konq_misc.cc \
                   konq_frame.cc \
                   konq_actions.cc \
                   konq_profiledlg.cc
linktest_LDADD = $(lib_LTLIBRARIES) \
	$(top_builddir)/konqueror/htmlview/libkonqhtmlview.la \
	$(top_builddir)/konqueror/iconview/libkonqiconview.la \
	$(top_builddir)/konqueror/listview/libkonqlistview.la \
	$(top_builddir)/konqueror/dirtree/libkonqdirtree.la $(LIB_KDECORE)

linktest_LDFLAGS = $(konqueror_LDFLAGS)



[prev in list] [next in list] [prev in thread] [next in thread]