[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Bug#2561: kfm hangs at suns with long hostnames
From:       AndreaS Maier <andi () cosy ! sbg ! ac ! at>
Date:       2000-01-25 16:59:37
[Download RAW message or body]


Package: kfm
Version: 1.1.2

I am using: Solaris7 (SunOS 5.7) with patches 11/99
            kde 1.1.2 precompiled (from your ftp server)

Bug in 'kdelibs-1.1.2/kfmlib/kfm.cpp', function 'displayName' lines 33-57:
	kfm.cpp:49:	if (gethostname(name, 25) == 0)

If we have a long hostname (25 chars or more, like an FQN) the string in
'name' will not be null-terminated. SUN man pages say:
	The  returned name is null-terminated unless insufficient space
	is provided.

The result is that the socket for kioslave to talk to kfm is not set up in
a usable way.

Patch: use 'gethostname(name, 2500)' or check in 'name' for null
	termination.


Bug in 'kdelibs-1.1.2/kfmlib/kfm.cpp', function 'displayName' lines 33-57:
	kfm.cpp:43:	if ( d.find( '.' ) == -1 )
				d += ".0";

I think that this line of code should give a ':0.0' display name if it is
':0', but this does not work if you use FQNs (e.g. mail.cosy.sbg.ac.at:0)


Thank you,
-andi

-- 
| Andreas Maier                     University of Salzburg               |
| (andi@cosy.sbg.ac.at)             Department of Computing Sciences     |
| Tel. +43/(0)662/8044-6339         Jakob Haringerstr. 2                 |
| Fax. +43/(0)662/8044-611          5020 Salzburg / Austria, Europe      |

[prev in list] [next in list] [prev in thread] [next in thread]