[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kdebase/konqueror
From:       David Faure <faure () kde ! org>
Date:       1999-11-28 3:33:54
[Download RAW message or body]

On Sun, Nov 28, 1999 at 05:42:53AM +0100, Simon Hausmann wrote:
> 
> 
> On Sun, 28 Nov 1999, David Faure wrote:
> 
> > On Sat, Nov 27, 1999 at 09:57:40PM +0100, Simon Hausmann wrote:
> > > 
> > > 
> > > On Sat, 27 Nov 1999, David Faure wrote:
> > > 
> > > > On Sat, Nov 27, 1999 at 08:23:12PM +0100, CVS by shausman wrote:
> > > > > 
> > > > > kdebase/konqueror konq_mainview.cc,1.292,1.293
> > > > > Author: shausman
> > > > > CVSROOT: /home/kde
> > > > > Sat Nov 27 20:23:12 MET 1999
> > > > > Update of /home/kde/kdebase/konqueror
> > > > > In directory zeus:/tmp/cvs-serv14184
> > > > > 
> > > > > Modified Files:
> > > > > 	konq_mainview.cc 
> > > > > Log Message:
> > > > > - mailto: hack (had to duplicate the hack/code :-(
> > > > Yes, Konqueror can't use KRun for everything, so it has
> > > > to check for mailto: (OTOH, when a mailto: is found, it could
> > > > use KRun, no ?)
> > > 
> > > OK, yes, we can do a strncmp( "mailto:" ... and then allocate a new KRun
> > > instance.
> > > 
> > > However we cannot use KonqRun, because then we cannot properly disable the
> > > rotating gear. (hack: connect to the finished() signal of KRun
> > > only for "mailto:" urls ... )
> > 
> > I don't get that.
> > Why is it different from... say clicking on a file that launches an external
> > program via KRun ? Say a kword file, for instance.
> > (I wanted to say "text file" but it starts konq_textview, bad example !)
> > 
> > In both cases, konqueror just "shoots and forgets" and the rotating
> > gear shouldn't even start (or if it does in the kword case, it should stop fast)
> 
> The problem is:
> We enable the rotating gear as soon as we launch our KonqRun instance.
> It (the gear animation) is stopped as soon as we know that we either can't
> handle the url (at the end of ::openView(), which returns to
> foundMimeType() ) or when the view finished (or even aborted) loading the
> url.
> 
> However the mailto: case is different. foundMimeType() never gets called,
> and we therefore can't disable the rotating gear.
> 
> One thing though is that KRun emits the finished() signal. It does so in
> case of the mailto: url, too.
> 
> The problem with that though was to find out how KonqRun "finished"
> (normal -> view embedding, external app or even that mailto: hack, where
> no foundMimeType() is called) .
> 
> But I just had a closer look at the stuff again, and I found a solution to
> get rid of the mailto:-hack-duplication :)
> 
> Clicking on mailto: links works now fine here :-) , without mailto: in
> Konqueror itself :-)

I knew that a well-asked question would lead your powerful brain
to the correct solution :-)

Will have a look tomorrow.
(Hey Simon, it's late for you too ! Bedtime !) :-)

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]