[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    RE: Open Location... doesn't allow for URL filtering
From:       Simon Hausmann <shaus () uermel ! med ! Uni-Magdeburg ! DE>
Date:       1999-10-28 9:17:05
[Download RAW message or body]



On Thu, 28 Oct 1999, David Faure wrote:

> > David Faure wrote:
> > > 
> > > On Wed, Oct 27, 1999 at 04:36:01PM -0700, Yves Arrouye wrote:
> > > > Hi,
> > > >
> > > > In Konqueror, URLs entered in the address bar are being filtered by
> plugins
> > > > (eg konq_searcher), and that's really cool. But not the ones entered
> in the
> > > > Open Location... dialog box. Shouldn't things you enter here and on
> the
> > > > address bar behave the same, thus changing slotOpenLocation so that:
> > > >
> > > >       openURL( (KonqChildView *)m_currentView, u.ascii() );
> > > >
> > > > is replaced by:
> > > >
> > > >       KonqURLEnterEvent ev( u );
> > > >       QApplication::sendEvent( this, &ev );
> > > >
> > > > (If so, I can just commit the change.)
> > > 
> > > If this works, feel free to commit.
> > > (I'm surprised by the QApplication::sendEvent - won't this open the URL
> > > in _all_ windows ? Isn't there a way to call it on the current window
> only ?)
> > 
> > My understanding is that that's what the this is: the target for the
> > event, in this case the KonqMainView that got 
> > slotOpenLocation() called on it.
> oops, didn't notice the "this".
> 
> ok then.
> 
> Another way is to directly call the method (since it's the same class & same
> instance),
> but that doesn't really matter.

Calling openURL() directly would break the filtering mechanism for
konq_searcher. So although it might look stupid to send an event to
"itself" it is a requirement :)

Ciao,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]