[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KDE1.1.2/PATCH - works nicely
From:       "Bjarni R. Einarsson" <bre () netverjar ! is>
Date:       1999-08-31 17:40:35
[Download RAW message or body]

On Tue, Aug 31, 1999 at 06:48:02PM +0200, Waldo Bastian wrote:
> 
> I just discovered it is c) :-)
>
> I have attached a patch that consists of 1c) and 4.
> 
> If you can check that this patch gives the same test-results as patch7 then we 
> should apply this.

The results are very, very close.  I think the differences are below
the noise level.  I've updated the file on my web page, in case you
want to take a look:

    http://www.mmedia.is/~bre/programs/khtmlw.memleak.patch.txt

> That solves bug 1812 I think.

I agree.  Mission accomplished, now I can go back to being a user (well,
and a translator). :-)

> Then we can have a look at the pCache stuff. It would be nice if we could
> fix it, but it isn't very urgent. It is clear that it leaks but not very 
> hard. I think it is worse if we change something there and break something.

Lars pointed out one thing it does break (overlays, darnit).

I would propose that this be solved by having setOverlay copy the
object from the cache, instead of just referencing it. Memory overhead
would be minimal since QPixmaps are shared automatically.  That would
require another delete in the destructor, but hey, the more the
merrier.  (I won't give you guys a hard time if you decide not to. ;-)

> I have commited 5) since it doesn't hurt.
> 
> Is 3) related to a bug? 

The GIF thing?

Just something I bumped into... figured it might save someone some CPU
cycles down the line.  Not important, but not quite worthless either.

...

Since I've got your attention, I've a couple of feature requests for
KDE 2.0:

  Please give users the option of disabling (permanently and on
  a page-per-page basis) animated .gifs.  When using old HW,
  (e.g. a 386 or 486) as X terminals, animated gifs are a real
  pain in the neck - but almost everything else works fine.
  Other than that kfm is great for squeezing some extra use out
  of such machines.

  Also, I saw someone requesting more intelligent dragging and
  dropping of URLs between browser windows... I'd second that
  request. Drag'n'drop is my favorite way to surf (or would be
  if it was supported by kfm), today I make do by creating a new
  window for each new page, and closing it when I'm done.

-- 
Bjarni R. Einarsson                           PGP: 02764305, B7A3AB89
 bre@netverjar.is           -><-           http://www.mmedia.is/~bre/

        Bullshit makes the flowers grow & thats beautiful.

[prev in list] [next in list] [prev in thread] [next in thread]