[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    RE: http://lists.kde.org/?l=kde-devel&m=93518510319562&w=2
From:       Dawit Alemayehu <adawit () earthlink ! net>
Date:       1999-08-27 5:05:16
[Download RAW message or body]

On Thu, 26 Aug 1999, David Faure wrote:
> [PNG and other image format Thumbnail support in kfm]
> 
>  	KMimeType *mime = KMimeType::getMagicMimeType( _url );
> -	if ( strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
> +	if ( strcmp( mime->getMimeType(), "image/x-bmp" ) == 0 ||
>  	     strcmp( mime->getMimeType(), "image/gif" ) == 0 ||
> -	     strcmp( mime->getMimeType(), "image/bmp" ) == 0 ||  
> -                            // Added bmp, because it seems to work. David.
> +	     strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
> +	     strcmp( mime->getMimeType(), "image/png" ) == 0 ||
> +	     strcmp( mime->getMimeType(), "image/tiff" ) == 0 ||
> +	     strcmp( mime->getMimeType(), "image/x-xbm" ) == 0 ||
>  	     strcmp( mime->getMimeType(), "image/x-xpm" ) == 0 )
> 
> I am okay for adding PNG, XBM and TIFF, but is BMP "bmp" or "x-bmp" ?
> 
> Well, all this could be replaced by :
> 
>  if ( strncmp( mime->getMimeType(), "image/", 6 ) == 0 )
> 
> couldn't it ? That would solve all those problems at once ! ;)

It could, but do we support all known image formats ?  What happens if we
encounter some unknown/unsupported image format ? In this case the first
explicit patch seems to be the way to go ...  Should I apply this ?

Cheers,
Dawit A.   

[prev in list] [next in list] [prev in thread] [next in thread]