[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    RE: http://lists.kde.org/?l=kde-devel&m=93518510319562&w=2
From:       David Faure <David.Faure () CRAMER ! CO ! UK>
Date:       1999-08-26 8:38:00
[Download RAW message or body]

[PNG and other image format Thumbnail support in kfm]

 	KMimeType *mime = KMimeType::getMagicMimeType( _url );
-	if ( strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
+	if ( strcmp( mime->getMimeType(), "image/x-bmp" ) == 0 ||
 	     strcmp( mime->getMimeType(), "image/gif" ) == 0 ||
-	     strcmp( mime->getMimeType(), "image/bmp" ) == 0 ||  
-                            // Added bmp, because it seems to work. David.
+	     strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/png" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/tiff" ) == 0 ||
+	     strcmp( mime->getMimeType(), "image/x-xbm" ) == 0 ||
 	     strcmp( mime->getMimeType(), "image/x-xpm" ) == 0 )

I am okay for adding PNG, XBM and TIFF, but is BMP "bmp" or "x-bmp" ?

Well, all this could be replaced by :

 if ( strncmp( mime->getMimeType(), "image/", 6 ) == 0 )

couldn't it ? That would solve all those problems at once ! ;)

--
David Faure
faure@kde.org - KDE developer
david@mandrakesoft.com - Mandrake
david.faure@cramer.co.uk - Cramer Systems

[prev in list] [next in list] [prev in thread] [next in thread]