[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: A couple of minor changes in kfmgui
From:       Waldo Bastian <bastian () suse ! de>
Date:       1999-08-23 9:49:40
[Download RAW message or body]

On Sat, 21 Aug 1999, Dawit Alemayehu wrote:
> 
> Greetings,
> 
> Duplicated Code:
> 
> When adding a cut feature to "kfm",  I discovered ( by coincidence ) that there
> was a difference when opening a URL with the File->Open Location [CTRL-O] dialog
> box and the Location toolbar box.  The cause is yet another unnecessarily
> duplicated code.  Both of these methods could share a common function to
> scan and forward the user input.  Hence the patch below.
> 
> Bug #1780 ( 1st part only ):
> 
> The patch also includes a fix?? for folks who consider the view not getting the
> focus, once a user entered a URL in either of the dialog boxes mentioned above,
> a bug. I do not think it is, though I must admit it makes keyboard navigation
> somewhat easier ( read: I like it ).  Anyway, the patch is commented out by
> default.  If you want to try it out, uncomment it.  It is line #52.

Looks good.Please commit it. Can you also include this keyboard
navigation fix. It makes kfm slightly more convenient to use IMHO.

Cheers,
Waldo

[prev in list] [next in list] [prev in thread] [next in thread]