[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Already Fixed Bugs
From:       Dawit Alemayehu <adawit () earthlink ! net>
Date:       1999-07-26 21:46:34
[Download RAW message or body]

Hello,

On Mon, 26 Jul 1999, Waldo Bastian wrote:
> Dawit Alemayehu wrote:
> 
> > Anyways,  I have included the patch for anyone interested in giving it a try.
> > I really would appreciate the feedback.  I can also ask the bug reporter to
> > try the patch if he built KDE out of the source.  To test the patch, please
> > have look at
> > 
> >         http://www.glinx.com/~hclsmith/
> > 
> > before and after you apply the patch. PLEASE NOTE that this patch is only for
> > KDE_1_1_BRANCH.  KURL in the head branch has been re-designed ( much more
> > cleanly I might add ).  However, it still does not handle ( at least KURL
> > by itself ) pages like the one mentioned above.  But before fixing the one in
> > the head branch, I want to discuss the options as there are several available.
> > This is what I meant above by "it is an entirely different topic" above.
> 
> What is this patch supposed to fix? 

This fixes bug#1556 ( http://bugs.kde.org/db/15/1556.html ).  The same bug was
was subject of a previous discussion and was originally reported as
bug#1472.  Here is a link to that thread (http://lists.kde.org/?t=93031866600001&w=2&d=1&r=1).
The best way to see the bug is to browse the above link.  In that page you will
see lots of links with missing images.  This is caused by the above bug. 
Basically the patch ONLY fixes KURL's inability to understand URL's that have
no protocol part ( http, ftp etc ).  Nothing more nothing less.

> the patch looks very dirty to me.

I know it is not the most elegant patch.  But even then my patch simply
amounts to a hack for fixing the bug.  It works great for me and have not yet
broken anything.  Perhaps It can be cleaned up more, but I do not have enough
time to spend on it right now.  This is mainly why I am hesitant about
committing it into CVS ( a frozen on at that ).  But if more folks test it
and have no problems with it then it may be okay.

BTW, I have found out that KURL in the HEAD has the same problem.  However, I
am working on an elegant fix for that.  My plan is to add ( make available for
adding ?? ) KFilteredURL to kdebase/kdecore to assist KURL in just such cases. 
KFilteredURL would simply inherit from KURL and override the ::parse (...)
method so that it can screen URL's sent by end-user apps for validity.  This
means that apps that want such services would simply use KFilteredURL as a drop
in replacement for KURL.  Anyways, I will post more on this as I get a working
code ... 

Hmmm .... maybe ignoring the issue in 1.1 and just fixing it in 2.0 is a
better route ???

Regards,
Dawit A.

[prev in list] [next in list] [prev in thread] [next in thread]