[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: konqueror and builtin views
From:       Simon Hausmann <tronical () gmx ! net>
Date:       1999-04-29 19:51:37
[Download RAW message or body]


On Thu, 29 Apr 1999, David Faure wrote:
> > Here's my idea about the OPFrame modification:
> > When a part gets attached to an OPFrame we check whether the object is a
> > local object.
> > If it is a remote object then we continue with the good old style of using
> > QXEmbed.
> > But if it is a local object then we start hacking ;-) :
> > In the attach() function we get a Part_ptr as argument, which we can't
> > cast over to an OPPartIf. But here OPPartIf::s_lstParts is our friend
> > since every process local Part is listed in there. So we search in this
> > list by comparing the unique part id.
> > Now that we have found the proper OPPartIf object, we can directly access
> > it's assigned QWidget and reparent it to the OPFrame itself.
> > That's it :-) (almost)
> Look ok to me
> (though I'm not expert enough yet)
> Are we sure that all part containers are OPFrames ?

Yes. Anyone not using OPFrame for embedding Parts but instead doing all
the work "manually" is crazy ;-)
 
> Well, let's wait a little, but if this lasts too long (it's strange we have 
> no news from Torben at all), then let's switch to 2.2.6 and disable
> temporarily the trader stuff.

I fully agree. 

Then Reggie will have to live without embedding ;-)

> > > > Should we rather do the qwidget-embedding "manually" in Konqy? Or do you
> > > I think lots of other apps that embed local parts will be happy to benefit
> > > >from it. *All* koffice apps, to start with, embed a local part.
> > > And future OP-aware apps will be able to use it as well.
> > 
> > Yes, and even KOffice apps resize faster in opaque mode, since the root
> > view is attached to an OPFrame in the KOffice MainWindow.
> great.
> 
> Drawback for konqueror: it means reverting to using OPFrame always !

Hm, that's true. :-(
 
> Or does konqueror implements in fact a better optimisation of the one you
> suggest ?
> In konqueror now, there isn't even an OPFrame object built for the local
> views. The view (which is a QWidget) is reparented directly into the main
> view, and the main view directly into the main window.
> But does this make a real difference ? No idea.

I don't think an additional QWidget will slow down too much.

> -- 
> David FAURE
> david.faure@insa-lyon.fr, faure@kde.org
> http://www.insa-lyon.fr/People/AEDI/dfaure/index.html 
> KDE, Making The Future of Computing Available Today
> 


Ciao,
  Simon

--
Simon Hausmann       <hausmann@kde.org>
http://www.kde.org/  <tronical@gmx.net>

[prev in list] [next in list] [prev in thread] [next in thread]