[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: khtmlw bug with <li></li>
From:       Waldo Bastian <bastian () ens ! ascom ! ch>
Date:       1999-01-22 15:26:37
[Download RAW message or body]

David Faure wrote:
> 
> > I have kfm and kfmw. :)
> :)
> 
> > My guess is that an extra vspace_inserted=true somewhere could help..
> Lars' commit did that.
> and
> @@ -3327,7 +3327,8 @@ void KHTMLWidget::parseH( HTMLClueV *_cl
>                         }
>                 }
>                 // Start a new flow box
> -               newFlow(_clue);
> +               if(!flow)
> +                   newFlow(_clue);
> 
>                 flow->setHAlign( align );

Doesn't this bring you into trouble when you already have flow?
I mean... you call flow->setHAlign( align) which will also affect
that part of the flow which is above the header.

I would think that the right solution would be not to create
a flow explicitly during the handling of "<li>". 

On a related note: Is it really necassery for <Hx> to make the 
flow? Can't it just do "flow=0"? When it is actually needed, a
flow will be created anyway. You might need to set divHAlign
for that and restore it in the popBlock.

Cheers,
Waldo (who doesn't has any sources nearby)

[prev in list] [next in list] [prev in thread] [next in thread]