'Re: Review Request 130001: Fix Selecting of Newly Created Items in Parent Folder'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 130001: Fix Selecting of Newly Created Items in Parent Folder
From:       Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date:       2017-03-14 10:59:35
Message-ID: 20170314105935.8720.87116 () mimi ! kde ! org
[Download RAW message or body]

--===============1508959066792982649==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130001/#review102836
-----------------------------------------------------------



Thanks for the patch.

Instead of normalizing the urls in Dolphin, we should try to find the root cause of \
the problem (or otherwise fix it in KIO).

How to you create the new items?

- Emmanuel Pescosta


On March 10, 2017, 4:13 a.m., Tsu Jan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130001/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 4:13 a.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> After going up from a folder to its parent, created items aren't selected in the \
> parent folder because of a double slash in the url (whose origin is unknown to me). \
> This is a workaround. 
> 
> Diffs
> -----
> 
> src/views/dolphinview.cpp 63f6252e 
> 
> Diff: https://git.reviewboard.kde.org/r/130001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tsu Jan
> 
> 


--===============1508959066792982649==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130001/">https://git.reviewboard.kde.org/r/130001/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch.

Instead of normalizing the urls in Dolphin, we should try to find the root cause of \
the problem (or otherwise fix it in KIO).

How to you create the new items?</pre>
 <br />









<p>- Emmanuel Pescosta</p>


<br />
<p>On March 10th, 2017, 4:13 a.m. CET, Tsu Jan wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.</div>
<div>By Tsu Jan.</div>


<p style="color: grey;"><i>Updated March 10, 2017, 4:13 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After going up from a folder to its parent, created \
items aren't selected in the parent folder because of a double slash in the url \
(whose origin is unknown to me). This is a workaround.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/views/dolphinview.cpp <span style="color: grey">(63f6252e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130001/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1508959066792982649==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic