[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129662: Dolphin: "Show Filter Bar" action should be a toggle
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-03-07 13:14:30
Message-ID: 20170307131430.27981.70009 () mimi ! kde ! org
[Download RAW message or body]
--===============0556473090494273057==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 1, 2017, 11:45 a.m., Kai Uwe Broulik wrote:
> > This broke keyboard interaction with the filter bar.
> >
> > I have it configured to always show the filter bar. Now when I press Ctrl+I with \
> > the filter bar shown but not focused, it just closes it, rather than moving focus \
> > to it...
>
> Kai Uwe Broulik wrote:
> I suggest to revert this until we have a better solution as this is a serious \
> usability regression. I'd rather not have a visible checkbox there than breaking a \
> decade of muscle memory.
+1
And here is the better version https://git.reviewboard.kde.org/r/127054/ which I have \
completely forgotten ...
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129662/#review102691
-----------------------------------------------------------
On Feb. 18, 2017, 11:05 p.m., Don Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129662/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 11:05 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> The existing code suggests that the show filter bar action should be a
> KToggleAction. DolphinViewContainer emits a showFilterBarChanged signal
> that is connected to DolphinMainWindow::updateFilterBarAction() to call
> setChecked() on the show filter bar action, which currently does nothing
> because the show filter bar action is not a checkable action. I've
> changed the show filter bar action to a KToggleAction, and updated the
> code to make it function as a toggle as I believe it was intended. If
> this was not the intention, then the existing code related to
> DolphinMainWindow::updateFilterBarAction() should be removed as they are
> not doing anything.
>
>
> Diffs
> -----
>
> src/dolphinmainwindow.h 7003e94
> src/dolphinmainwindow.cpp e5103fd
> src/dolphinviewcontainer.cpp 4e625c7
>
> Diff: https://git.reviewboard.kde.org/r/129662/diff/
>
>
> Testing
> -------
>
> manual testing. can turn on/off bar with keyboard shortcut, toolbar button. \
> toolbar button and menu state reflects the status of the filter bar.
>
> File Attachments
> ----------------
>
> filter bar off
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/b38ead2b-910a-4226-b081-24a7c53c7651__filteroff.png
> filter bar on
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/d702a124-b909-4302-9848-ccc6e6223828__filteron.png
>
>
> Thanks,
>
> Don Nguyen
>
>
--===============0556473090494273057==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129662/">https://git.reviewboard.kde.org/r/129662/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 1st, 2017, 11:45 a.m. CET, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This broke keyboard interaction with the filter \
bar.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have it configured to always show the filter bar. \
Now when I press Ctrl+I with the filter bar shown but not focused, it just closes it, \
rather than moving focus to it...</p></pre> </blockquote>
<p>On March 7th, 2017, 2 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suggest to revert this until we have a better solution as this is a serious usability \
regression. I'd rather not have a visible checkbox there than breaking a decade of \
muscle memory.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1
And here is the better version https://git.reviewboard.kde.org/r/127054/ which I have \
completely forgotten ...</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On February 18th, 2017, 11:05 p.m. CET, Don Nguyen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Don Nguyen.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2017, 11:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The existing code suggests that the show filter bar action should be a \
KToggleAction. DolphinViewContainer emits a showFilterBarChanged signal that is \
connected to DolphinMainWindow::updateFilterBarAction() to call setChecked() on the \
show filter bar action, which currently does nothing because the show filter bar \
action is not a checkable action. I've changed the show filter bar action to a \
KToggleAction, and updated the code to make it function as a toggle as I believe it \
was intended. If this was not the intention, then the existing code related to
DolphinMainWindow::updateFilterBarAction() should be removed as they are
not doing anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">manual testing. can turn on/off bar with keyboard shortcut, toolbar \
button. toolbar button and menu state reflects the status of the filter bar.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinmainwindow.h <span style="color: grey">(7003e94)</span></li>
<li>src/dolphinmainwindow.cpp <span style="color: grey">(e5103fd)</span></li>
<li>src/dolphinviewcontainer.cpp <span style="color: grey">(4e625c7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129662/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/b38ead2b-910a-4226-b081-24a7c53c7651__filteroff.png">filter \
bar off</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/d702a124-b909-4302-9848-ccc6e6223828__filteron.png">filter \
bar on</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0556473090494273057==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic