[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129936: Added a 'save search' button to the dolphin search bar. Not ready to be s
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-02-18 22:15:30
Message-ID: 20170218221530.13662.59399 () mimi ! kde ! org
[Download RAW message or body]
--===============7828081029149947046==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129936/#review102551
-----------------------------------------------------------
Thanks for the patch!
I don't think that we should add another way to bookmark the current search.
The same can already be achieved by either dragging it to the places panel or by \
doing RMB -> Add to places. The search folders then appears in the group "Search \
for". From a user point of view this is the same as bookmarking a normal folders, \
thus the user is already aware of this workflow.
What do you (and others) think?
- Emmanuel Pescosta
On Feb. 9, 2017, 1:27 p.m., Ryan McCoskrie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129936/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 1:27 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Bug 269332: Save Search button
>
>
> Diffs
> -----
>
> src/search/dolphinsearchbox.h 5063c2b
> src/search/dolphinsearchbox.cpp 5d5906b
>
> Diff: https://git.reviewboard.kde.org/r/129936/diff/
>
>
> Testing
> -------
>
> - Discovered testing builds are broken, built without.
> - Saved a search for 'foo' in my home directory.
> - The name was "(I18N_EMPTY_MESSAGE)" but it was a valid link.
>
>
> Thanks,
>
> Ryan McCoskrie
>
>
--===============7828081029149947046==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129936/">https://git.reviewboard.kde.org/r/129936/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch!
I don't think that we should add another way to bookmark the current search.
The same can already be achieved by either dragging it to the places panel or by \
doing RMB -> Add to places. The search folders then appears in the group \
"Search for". From a user point of view this is the same as bookmarking a \
normal folders, thus the user is already aware of this workflow.
What do you (and others) think?</pre>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On February 9th, 2017, 1:27 p.m. CET, Ryan McCoskrie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Ryan McCoskrie.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2017, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Bug 269332: Save Search button</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Discovered testing \
builds are broken, built without.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Saved a search for 'foo' \
in my home directory.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">The name was "(I18N_EMPTY_MESSAGE)" but \
it was a valid link.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/search/dolphinsearchbox.h <span style="color: grey">(5063c2b)</span></li>
<li>src/search/dolphinsearchbox.cpp <span style="color: grey">(5d5906b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129936/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7828081029149947046==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic