[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-02-13 16:41:44
Message-ID: 20170213164144.13662.24352 () mimi ! kde ! org
[Download RAW message or body]
--===============7712980753695192989==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review102525
-----------------------------------------------------------
src/dolphinmainwindow.h
<https://git.reviewboard.kde.org/r/129044/#comment68334>
Check your editor settings and enable "ensure single trailing newline" and then \
open+save dolphinmainwindow.{h,cpp}. (please note that I don't use Atom, so the \
settings screenshot I have found may be outdated ;) )
- Emmanuel Pescosta
On Feb. 13, 2017, 12:39 p.m., arnav dhamija wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 12:39 p.m.)
>
>
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and \
> convenient way for saving the URLs of complicated selections of files. To make this \
> feature more useful, there have been suggestions to have a dedicated shortcut and \
> GUI button for accessing the ioslave in a Split window. This patch adds a QAction \
> in the DolphinMainWindow class for this purpose. The shortcut is subject to change \
> and is currently set as Ctrl+**S**tash. By default, the action is visible in the \
> View menu and the Toolbar of Dolphin.
>
> Diffs
> -----
>
> src/dolphinmainwindow.h 7003e94
> src/dolphinmainwindow.cpp 4d97fc1
> src/dolphintabpage.h 9d18088
> src/dolphintabpage.cpp c674e1e
> src/dolphinui.rc f197af4
>
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot of the button in the toolbar
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
>
>
> Thanks,
>
> arnav dhamija
>
>
--===============7712980753695192989==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129044/">https://git.reviewboard.kde.org/r/129044/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129044/diff/5/?file=491210#file491210line520" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/dolphinmainwindow.h</a> <span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">517</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check your editor \
settings and enable "ensure single trailing newline" and then open+save \
dolphinmainwindow.{h,cpp}. (please note that I don't use Atom, so the settings \
screenshot I have found may be outdated ;) )</pre> </div>
</div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On February 13th, 2017, 12:39 p.m. CET, arnav dhamija wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel \
Pescosta.</div> <div>By arnav dhamija.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2017, 12:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The <a href="https://github.com/KDE/kio-stash" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">stash:/ ioslave</a> provides an easy and convenient way for saving the URLs \
of complicated selections of files. To make this feature more useful, there have been \
suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in \
a Split window. This patch adds a QAction in the DolphinMainWindow class for this \
purpose. The shortcut is subject to change and is currently set as Ctrl+<strong \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">S</strong>tash. By default, the action is visible in the View menu and the \
Toolbar of Dolp hin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinmainwindow.h <span style="color: grey">(7003e94)</span></li>
<li>src/dolphinmainwindow.cpp <span style="color: grey">(4d97fc1)</span></li>
<li>src/dolphintabpage.h <span style="color: grey">(9d18088)</span></li>
<li>src/dolphintabpage.cpp <span style="color: grey">(c674e1e)</span></li>
<li>src/dolphinui.rc <span style="color: grey">(f197af4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129044/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png">Screenshot \
of the button in the toolbar</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7712980753695192989==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic