[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129861: informationpanel: don't change color of scrollarea's viewport
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-01-21 13:17:02
Message-ID: 20170121131702.31352.1500 () mimi ! kde ! org
[Download RAW message or body]
--===============8595887714006748067==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129861/#review102160
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On Jan. 21, 2017, 11:38 a.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129861/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 11:38 a.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Bugs: 366203
> https://bugs.kde.org/show_bug.cgi?id=366203
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This code was added a long time ago in b1c9b5126d, but the commit
> message doesn't explain why. If we remove it nothing seems to change and
> we fix the ugly background on the scrollbar when Breeze draws a frame
> around dockable panels.
>
> BUG: 366203
> FIXED-IN: 16.12.2
>
>
> Diffs
> -----
>
> src/panels/information/informationpanelcontent.cpp \
> d519ff12125f09e345928ec4c2d2f02a71428cf7
> Diff: https://git.reviewboard.kde.org/r/129861/diff/
>
>
> Testing
> -------
>
> Systemsettings -> Application Style -> Widget Style -> Configure button -> Frames \
> tab -> Check "Draw frames around dockable panels"
> Select some image in Dolphin, check the scrollbar in the information panel \
> with/without this patch.
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============8595887714006748067==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129861/">https://git.reviewboard.kde.org/r/129861/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On January 21st, 2017, 11:38 a.m. CET, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2017, 11:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=366203">366203</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This code was added a long time ago in b1c9b5126d, but the commit \
message doesn't explain why. If we remove it nothing seems to change and we fix \
the ugly background on the scrollbar when Breeze draws a frame around dockable \
panels.
BUG: 366203
FIXED-IN: 16.12.2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Systemsettings -> Application Style -> Widget \
Style -> Configure button -> Frames tab -> Check "Draw frames around \
dockable panels"</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Select some image in Dolphin, check the \
scrollbar in the information panel with/without this patch.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/panels/information/informationpanelcontent.cpp <span style="color: \
grey">(d519ff12125f09e345928ec4c2d2f02a71428cf7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129861/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8595887714006748067==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic