'Re: Review Request 129789: Don't overwrite custom icons for show_hidden_files action'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 129789: Don't overwrite custom icons for show_hidden_files action
From:       Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date:       2017-01-14 11:26:25
Message-ID: 20170114112625.32006.69862 () mimi ! kde ! org
[Download RAW message or body]

--===============0047802884539867065==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129789/#review102010
-----------------------------------------------------------


Ship it!




Ship It!

- Emmanuel Pescosta


On Jan. 7, 2017, 4:26 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129789/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 4:26 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 374508
> https://bugs.kde.org/show_bug.cgi?id=374508
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The show_hidden_files action by default has two possible icons, depeding on the \
> visibility of hidden files. But if the users selected a custom icon for this icon, \
> they probably don't want to lose it when toggling the action. 
> 
> Diffs
> -----
> 
> src/views/dolphinviewactionhandler.cpp 5c0b49cd206c371fd5dda83895dd93f9e1f37be2 
> 
> Diff: https://git.reviewboard.kde.org/r/129789/diff/
> 
> 
> Testing
> -------
> 
> Setting a custom icon as described in the bug now works.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
> 


--===============0047802884539867065==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129789/">https://git.reviewboard.kde.org/r/129789/</a>
  </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Emmanuel Pescosta</p>


<br />
<p>On January 7th, 2017, 4:26 p.m. CET, Elvis Angelaccio wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Elvis Angelaccio.</div>


<p style="color: grey;"><i>Updated Jan. 7, 2017, 4:26 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=374508">374508</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The show_hidden_files action by default has two \
possible icons, depeding on the visibility of hidden files. But if the users selected \
a custom icon for this icon, they probably don't want to lose it when toggling the \
action.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Setting a custom icon as described in the bug now \
works.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/views/dolphinviewactionhandler.cpp <span style="color: \
grey">(5c0b49cd206c371fd5dda83895dd93f9e1f37be2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129789/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============0047802884539867065==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic