[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129604: clazy warning fix for gci
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2016-12-03 14:59:34
Message-ID: 20161203145934.23280.38309 () mimi ! kde ! org
[Download RAW message or body]
--===============6229720395531763706==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 3, 2016, 3:54 p.m., Emmanuel Pescosta wrote:
> > CMakeLists.txt, line 11
> > <https://git.reviewboard.kde.org/r/129604/diff/2/?file=486947#file486947line11>
> >
> > Why the version bump?
>
> Elvis Angelaccio wrote:
> `Q_ENUM` is new in Qt 5.5, see https://woboq.com/blog/q_enum.html
Ah ok sorry then, missed the Q_ENUMS -> Q_ENUM
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129604/#review101239
-----------------------------------------------------------
On Dec. 3, 2016, 2:21 p.m., Spencer Brown wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129604/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 2:21 p.m.)
>
>
> Review request for Dolphin and Elvis Angelaccio.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Fixes 5 warnings reported in clazy - for googlecodein
>
>
> Diffs
> -----
>
> CMakeLists.txt 2d5c1c0
> src/kitemviews/kitemlistcontroller.h b8a93ed
> src/tests/kfileitemmodeltest.cpp 6c45e11
> src/tests/kitemsettest.cpp 0d14e20
>
> Diff: https://git.reviewboard.kde.org/r/129604/diff/
>
>
> Testing
> -------
>
> Confirmed that clazy does not report the warnings again from a clean build, - or \
> any new ones.
>
> Thanks,
>
> Spencer Brown
>
>
--===============6229720395531763706==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129604/">https://git.reviewboard.kde.org/r/129604/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 3rd, 2016, 3:54 p.m. CET, <b>Emmanuel \
Pescosta</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129604/diff/2/?file=486947#file486947line11" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">11</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">set(QT_MIN_VERSION \
"5.<span class="hl">4</span>.0")</pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">11</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">set(QT_MIN_VERSION \
"5.<span class="hl">5</span>.0")</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the version \
bump?</pre> </blockquote>
<p>On December 3rd, 2016, 3:55 p.m. CET, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Q_ENUM</code> is new in Qt 5.5, see \
https://woboq.com/blog/q_enum.html</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah ok sorry \
then, missed the Q_ENUMS -> Q_ENUM</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On December 3rd, 2016, 2:21 p.m. CET, Spencer Brown wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Elvis Angelaccio.</div>
<div>By Spencer Brown.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2016, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixes 5 warnings reported in clazy - for \
googlecodein</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Confirmed that clazy does not report the warnings \
again from a clean build, - or any new ones.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d5c1c0)</span></li>
<li>src/kitemviews/kitemlistcontroller.h <span style="color: \
grey">(b8a93ed)</span></li>
<li>src/tests/kfileitemmodeltest.cpp <span style="color: grey">(6c45e11)</span></li>
<li>src/tests/kitemsettest.cpp <span style="color: grey">(0d14e20)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129604/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6229720395531763706==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic