[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129141: [search] Reload search view when file is deleted or copied
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2016-11-20 20:26:33
Message-ID: 20161120202633.32069.47783 () mimi ! kde ! org
[Download RAW message or body]
--===============1512942643980105458==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 20, 2016, 9:17 p.m., David Faure wrote:
> > src/kitemviews/kfileitemmodel.cpp, line 123
> > <https://git.reviewboard.kde.org/r/129141/diff/2/?file=485646#file485646line123>
> >
> > KDirLister::Keep was meant to be used for tree views, where listing a subdir \
> > shouldn't forget about the parent dir, it's still shown.
> > (while in an icon view or detailed list view, going to a different directory \
> > means we're not showing the previous directory anymore).
> > If this model can do both trees and lists, maybe the use of Keep should be \
> > conditional?
> If this model can do both trees and lists, maybe the use of Keep should be \
> conditional?
This is already implemented, see \
https://github.com/KDE/dolphin/blob/master/src/kitemviews/kfileitemmodel.cpp#L514
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129141/#review100978
-----------------------------------------------------------
On Nov. 16, 2016, 9:40 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129141/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 9:40 p.m.)
>
>
> Review request for Dolphin, David Faure and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> I'm not sure it is correct to use KDirLister::Keep
>
>
> Diffs
> -----
>
> src/kitemviews/kfileitemmodel.cpp 05f85a6
>
> Diff: https://git.reviewboard.kde.org/r/129141/diff/
>
>
> Testing
> -------
>
> Delete / create work. KDirLister::Keep should use only in search mode \
> (filenamesearch or baloosearch) ?
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============1512942643980105458==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129141/">https://git.reviewboard.kde.org/r/129141/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2016, 9:17 p.m. CET, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129141/diff/2/?file=485646#file485646line123" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kitemviews/kfileitemmodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">123</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_dirLister</span><span class="o">-></span><span \
class="n">openUrl</span><span class="p">(</span><span class="n">url</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">123</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">m_dirLister</span><span \
class="o">-></span><span class="n">openUrl</span><span class="p">(</span><span \
class="n">url</span><span class="p"><span class="hl">,</span></span><span class="hl"> \
</span><span class="n"><span class="hl">KDirLister</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">Keep</span></span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KDirLister::Keep was meant to be used for tree views, where listing a \
subdir shouldn't forget about the parent dir, it's still shown.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(while in an icon view or detailed list view, going to a different \
directory means we're not showing the previous directory anymore).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If this model can do both trees and lists, maybe the use of Keep should be \
conditional?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> If \
this model can do both trees and lists, maybe the use of Keep should be conditional?
This is already implemented, see \
https://github.com/KDE/dolphin/blob/master/src/kitemviews/kfileitemmodel.cpp#L514</pre>
<br />
<p>- Emmanuel</p>
<br />
<p>On November 16th, 2016, 9:40 p.m. CET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin, David Faure and Emmanuel Pescosta.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2016, 9:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not sure it is correct to use \
KDirLister::Keep</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Delete / create work. KDirLister::Keep should use only \
in search mode (filenamesearch or baloosearch) ?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(05f85a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129141/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1512942643980105458==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic