[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123270: Fix exports and avoid using sources already linked on tests.
From: Andrius da Costa Ribas <andriusmao () gmail ! com>
Date: 2016-04-22 17:23:11
Message-ID: 20160422172311.31741.61216 () mimi ! kde ! org
[Download RAW message or body]
--===============6553362525926200796==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123270/
-----------------------------------------------------------
(Updated Abril 22, 2016, 5:23 p.m.)
Status
------
This change has been discarded.
Review request for Dolphin and kdewin.
Repository: dolphin
Description
-------
When bringing dolphinvcs to the repo, dolphinprivate exports got messed up. This \
patch fixes it and also fixes building the tests by not using the sources already \
exported dolphinprivate, which is linked to those tests.
Diffs
-----
src/CMakeLists.txt 89a4e43
src/kitemviews/kitemset.h 385010f
src/tests/CMakeLists.txt 22a8b48
src/views/versioncontrol/kversioncontrolplugin.h e5a2678
Diff: https://git.reviewboard.kde.org/r/123270/diff/
Testing
-------
Built using MSVC2013. Dolphin works mostly fine. Three tests still do not pass but \
seem unrelated to this fix.
--- TEST OUTPUT ---
Running tests...
Test project V:/build/kde/dolphin/work/msvc2013-RelWithDebInfo-master
Start 1: kitemsettest
1/9 Test #1: kitemsettest ......................... Passed 0.22 sec
Start 2: kitemrangetest
2/9 Test #2: kitemrangetest ....................... Passed 0.03 sec
Start 3: kitemlistselectionmanagertest
3/9 Test #3: kitemlistselectionmanagertest ........ Passed 0.19 sec
Start 4: kitemlistcontrollertest
4/9 Test #4: kitemlistcontrollertest ..............***Failed 5.32 sec
Start 5: kfileitemlistviewtest
5/9 Test #5: kfileitemlistviewtest ................***Failed 5.37 sec
Start 6: kfileitemmodeltest
6/9 Test #6: kfileitemmodeltest ...................***Failed 175.96 sec
Start 7: kitemlistkeyboardsearchmanagertest
7/9 Test #7: kitemlistkeyboardsearchmanagertest ... Passed 0.31 sec
Start 8: kstandarditemmodeltest
8/9 Test #8: kstandarditemmodeltest ............... Passed 0.18 sec
Start 9: viewpropertiestest
9/9 Test #9: viewpropertiestest ................... Passed 0.20 sec
67% tests passed, 3 tests failed out of 9
Total Test time (real) = 188.13 sec
The following tests FAILED:
4 - kitemlistcontrollertest (Failed)
5 - kfileitemlistviewtest (Failed)
6 - kfileitemmodeltest (Failed)
Errors while running CTest
NMAKE : fatal error U1077: 'v:\dev-utils\bin\ctest.exe' : return code '0x8'
Stop.
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kitemlistcontrollertest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of \
KItemListControllerTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) QWARN : \
KItemListControllerTest::initTestCase() "Trying to convert empty KLocalizedString to \
QString." QWARN : KItemListControllerTest::initTestCase() "URL cannot be listed
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kitemlistcontrollertest-1XkOA3"
QWARN : KItemListControllerTest::initTestCase() Icon theme "oxygen" not found.
QDEBUG : KItemListControllerTest::initTestCase() kf5.kiconthemes: Couldn't find \
current icon theme, falling back to default. QWARN : \
KItemListControllerTest::initTestCase() Icon theme "oxygen" not found. QWARN : \
KItemListControllerTest::initTestCase() Error: standard icon theme "oxygen" not \
found! FAIL! : KItemListControllerTest::initTestCase() \
'spyDirectoryLoadingCompleted.wait()' returned FALSE. () \
q:\dolphin\src\tests\kitemlistcontrollertest.cpp(142) : failure location PASS : \
KItemListControllerTest::cleanupTestCase()
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KItemListControllerTest *********
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemlistviewtest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of \
KFileItemListViewTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) PASS : KFileItemListViewTest::initTestCase()
QWARN : KFileItemListViewTest::testGroupedItemChanges() "URL cannot be listed
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kfileitemlistviewtest-1XkOA3"
FAIL! : KFileItemListViewTest::testGroupedItemChanges() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemlistviewtest.cpp(99) : failure \
location PASS : KFileItemListViewTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemListViewTest *********
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemmodeltest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of \
KFileItemModelTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) PASS : KFileItemModelTest::initTestCase()
PASS : KFileItemModelTest::testDefaultRoles()
FAIL! : KFileItemModelTest::testDefaultSortRole() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(154) : failure location
PASS : KFileItemModelTest::testDefaultGroupedSorting()
FAIL! : KFileItemModelTest::testNewItems() 'itemsInsertedSpy.wait()' returned FALSE. \
() q:\dolphin\src\tests\kfileitemmodeltest.cpp(174) : failure location
FAIL! : KFileItemModelTest::testRemoveItems() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(188) : failure location
FAIL! : KFileItemModelTest::testDirLoadingCompleted() 'loadingCompletedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(208) : failure \
location FAIL! : KFileItemModelTest::testSetData() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(252) : failure \
location FAIL! : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating \
3) 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 5) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 8) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 1) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 3) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 5) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testChangeSortRole() 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(363) : failure location FAIL! : \
KFileItemModelTest::testResortAfterChangingName() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(405) : failure location
FAIL! : KFileItemModelTest::testModelConsistencyWhenInsertingItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(442) : failure location FAIL! : \
KFileItemModelTest::testItemRangeConsistencyWhenInsertingItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(481) : failure location FAIL! : \
KFileItemModelTest::testExpandItems() 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(539) : failure location FAIL! : \
KFileItemModelTest::testExpandParentItems() 'itemsInsertedSpy.wait()' returned FALSE. \
() q:\dolphin\src\tests\kfileitemmodeltest.cpp(669) : failure location
FAIL! : KFileItemModelTest::testMakeExpandedItemHidden() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(741) : failure \
location FAIL! : KFileItemModelTest::testRemoveFilteredExpandedItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(784) : failure location FAIL! : \
KFileItemModelTest::testSorting() 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(845) : failure location FAIL! : \
KFileItemModelTest::testIndexForKeyboardSearch() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(959) : failure location
FAIL! : KFileItemModelTest::testNameFilter() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1009) : failure location
PASS : KFileItemModelTest::testEmptyPath()
FAIL! : KFileItemModelTest::testRefreshExpandedItem() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1072) : failure \
location FAIL! : KFileItemModelTest::testRemoveHiddenItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1105) : failure location FAIL! : \
KFileItemModelTest::collapseParentOfHiddenItems() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1153) : failure location
FAIL! : KFileItemModelTest::removeParentOfHiddenItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1203) : failure \
location FAIL! : KFileItemModelTest::testGeneralParentChildRelationships() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1256) : failure location FAIL! : \
KFileItemModelTest::testNameRoleGroups() 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1343) : failure location FAIL! : \
KFileItemModelTest::testNameRoleGroupsWithExpandedItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1411) : failure \
location FAIL! : KFileItemModelTest::testInconsistentModel() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1448) : failure location FAIL! : \
KFileItemModelTest::testChangeRolesForFilteredItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1504) : failure \
location PASS : KFileItemModelTest::testChangeSortRoleWhileFiltering()
FAIL! : KFileItemModelTest::testRefreshFilteredItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1597) : failure \
location FAIL! : KFileItemModelTest::testCollapseFolderWhileLoading() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1657) : failure location FAIL! : \
KFileItemModelTest::testCreateMimeData() 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1630) : failure location FAIL! : \
KFileItemModelTest::testDeleteFileMoreThanOnce() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location
PASS : KFileItemModelTest::cleanupTestCase()
Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemModelTest *********
Thanks,
Andrius da Costa Ribas
--===============6553362525926200796==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123270/">https://git.reviewboard.kde.org/r/123270/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Abril 22, 2016, 5:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When bringing dolphinvcs to the repo, dolphinprivate \
exports got messed up. This patch fixes it and also fixes building the tests by not \
using the sources already exported dolphinprivate, which is linked to those \
tests.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built using MSVC2013. Dolphin works mostly fine. Three tests still do \
not pass but seem unrelated to this fix.
--- TEST OUTPUT ---
Running tests...
Test project V:/build/kde/dolphin/work/msvc2013-RelWithDebInfo-master
Start 1: kitemsettest
1/9 Test #1: kitemsettest ......................... Passed 0.22 sec
Start 2: kitemrangetest
2/9 Test #2: kitemrangetest ....................... Passed 0.03 sec
Start 3: kitemlistselectionmanagertest
3/9 Test #3: kitemlistselectionmanagertest ........ Passed 0.19 sec
Start 4: kitemlistcontrollertest
4/9 Test #4: kitemlistcontrollertest ..............***Failed 5.32 sec
Start 5: kfileitemlistviewtest
5/9 Test #5: kfileitemlistviewtest ................***Failed 5.37 sec
Start 6: kfileitemmodeltest
6/9 Test #6: kfileitemmodeltest ...................***Failed 175.96 sec
Start 7: kitemlistkeyboardsearchmanagertest
7/9 Test #7: kitemlistkeyboardsearchmanagertest ... Passed 0.31 sec
Start 8: kstandarditemmodeltest
8/9 Test #8: kstandarditemmodeltest ............... Passed 0.18 sec
Start 9: viewpropertiestest
9/9 Test #9: viewpropertiestest ................... Passed 0.20 sec
67% tests passed, 3 tests failed out of 9
Total Test time (real) = 188.13 sec
The following tests FAILED:
4 - kitemlistcontrollertest (Failed)
5 - kfileitemlistviewtest (Failed)
6 - kfileitemmodeltest (Failed)
Errors while running CTest
NMAKE : fatal error U1077: 'v:\dev-utils\bin\ctest.exe' : return code \
'0x8' Stop.
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kitemlistcontrollertest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing \
of KItemListControllerTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) QWARN : \
KItemListControllerTest::initTestCase() "Trying to convert empty \
KLocalizedString to QString." QWARN : KItemListControllerTest::initTestCase() \
"URL cannot be listed \
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kitemlistcontrollertest-1XkOA3" \
QWARN : KItemListControllerTest::initTestCase() Icon theme "oxygen" not \
found. QDEBUG : KItemListControllerTest::initTestCase() kf5.kiconthemes: Couldn't \
find current icon theme, falling back to default. QWARN : \
KItemListControllerTest::initTestCase() Icon theme "oxygen" not found. \
QWARN : KItemListControllerTest::initTestCase() Error: standard icon theme \
"oxygen" not found! FAIL! : KItemListControllerTest::initTestCase() \
'spyDirectoryLoadingCompleted.wait()' returned FALSE. () \
q:\dolphin\src\tests\kitemlistcontrollertest.cpp(142) : failure location PASS : \
KItemListControllerTest::cleanupTestCase()
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KItemListControllerTest *********
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemlistviewtest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing \
of KFileItemListViewTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) PASS : KFileItemListViewTest::initTestCase()
QWARN : KFileItemListViewTest::testGroupedItemChanges() "URL cannot be listed
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kfileitemlistviewtest-1XkOA3"
FAIL! : KFileItemListViewTest::testGroupedItemChanges() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemlistviewtest.cpp(99) : failure location PASS : \
KFileItemListViewTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemListViewTest *********
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemmodeltest.exe
v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing \
of KFileItemModelTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared \
(dynamic) release build; by MSVC 2013) PASS : KFileItemModelTest::initTestCase()
PASS : KFileItemModelTest::testDefaultRoles()
FAIL! : KFileItemModelTest::testDefaultSortRole() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(154) : failure \
location PASS : KFileItemModelTest::testDefaultGroupedSorting()
FAIL! : KFileItemModelTest::testNewItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(174) : failure \
location FAIL! : KFileItemModelTest::testRemoveItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(188) : failure location FAIL! : \
KFileItemModelTest::testDirLoadingCompleted() 'loadingCompletedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(208) : failure \
location FAIL! : KFileItemModelTest::testSetData() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(252) : failure \
location FAIL! : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating \
3) 'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 5) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 8) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 1) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 3) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 5) \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location FAIL! : \
KFileItemModelTest::testChangeSortRole() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(363) : failure location
FAIL! : KFileItemModelTest::testResortAfterChangingName() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(405) : failure location FAIL! : \
KFileItemModelTest::testModelConsistencyWhenInsertingItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(442) : failure location FAIL! : \
KFileItemModelTest::testItemRangeConsistencyWhenInsertingItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(481) : failure location FAIL! : \
KFileItemModelTest::testExpandItems() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(539) : failure location
FAIL! : KFileItemModelTest::testExpandParentItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(669) : failure location FAIL! : \
KFileItemModelTest::testMakeExpandedItemHidden() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(741) : failure \
location FAIL! : KFileItemModelTest::testRemoveFilteredExpandedItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(784) : failure location FAIL! : \
KFileItemModelTest::testSorting() 'itemsInsertedSpy.wait()' returned FALSE. \
() q:\dolphin\src\tests\kfileitemmodeltest.cpp(845) : failure location
FAIL! : KFileItemModelTest::testIndexForKeyboardSearch() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(959) : failure location FAIL! : \
KFileItemModelTest::testNameFilter() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1009) : failure location
PASS : KFileItemModelTest::testEmptyPath()
FAIL! : KFileItemModelTest::testRefreshExpandedItem() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1072) : failure location FAIL! : \
KFileItemModelTest::testRemoveHiddenItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1105) : failure \
location FAIL! : KFileItemModelTest::collapseParentOfHiddenItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1153) : failure location FAIL! : \
KFileItemModelTest::removeParentOfHiddenItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1203) : failure \
location FAIL! : KFileItemModelTest::testGeneralParentChildRelationships() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1256) : failure location FAIL! : \
KFileItemModelTest::testNameRoleGroups() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1343) : failure location
FAIL! : KFileItemModelTest::testNameRoleGroupsWithExpandedItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1411) : failure location FAIL! : \
KFileItemModelTest::testInconsistentModel() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1448) : failure \
location FAIL! : KFileItemModelTest::testChangeRolesForFilteredItems() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1504) : failure location PASS : \
KFileItemModelTest::testChangeSortRoleWhileFiltering() FAIL! : \
KFileItemModelTest::testRefreshFilteredItems() 'itemsInsertedSpy.wait()' \
returned FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1597) : failure \
location FAIL! : KFileItemModelTest::testCollapseFolderWhileLoading() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1657) : failure location FAIL! : \
KFileItemModelTest::testCreateMimeData() 'itemsInsertedSpy.wait()' returned \
FALSE. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1630) : failure location
FAIL! : KFileItemModelTest::testDeleteFileMoreThanOnce() \
'itemsInsertedSpy.wait()' returned FALSE. () \
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location PASS : \
KFileItemModelTest::cleanupTestCase()
Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemModelTest *********</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(89a4e43)</span></li>
<li>src/kitemviews/kitemset.h <span style="color: grey">(385010f)</span></li>
<li>src/tests/CMakeLists.txt <span style="color: grey">(22a8b48)</span></li>
<li>src/views/versioncontrol/kversioncontrolplugin.h <span style="color: \
grey">(e5a2678)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123270/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6553362525926200796==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic