[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 126904: Avoid checking if the right-clicked folder is in
From: Frank Reininghaus <frank78ac () googlemail ! com>
Date: 2016-02-10 21:38:27
Message-ID: 20160210213827.23891.74914 () mimi ! kde ! org
[Download RAW message or body]
--===============7059434412739120545==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126904/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 9:38 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin and Thomas Lübking.
Changes
-------
Submitted with commit d094c8ffe64d226d5afef50693a3bb04b360ed7b by Frank Reininghaus \
to branch master.
Repository: dolphin
Description
-------
This prevents that the setup of the PlacesItemModel queries Solid for the available \
devices, which can take some time.
Places can be added multiple times now using the context menu, but this has always \
been possible with drag and drop anyway.
See https://forum.kde.org/viewtopic.php?f=223&t=130617 for a dicsussion on this \
topic.
Diffs
-----
src/dolphincontextmenu.cpp af283cf
Diff: https://git.reviewboard.kde.org/r/126904/diff/
Testing
-------
The "Add to Places" entry is always enabled now in the context menu. I never observed \
a noticeable delay when right-clicking folders, but I am confident that this change \
removes the delay for the users who saw it.
Thanks,
Frank Reininghaus
--===============7059434412739120545==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126904/">https://git.reviewboard.kde.org/r/126904/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Thomas Lübking.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2016, 9:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit d094c8ffe64d226d5afef50693a3bb04b360ed7b by Frank \
Reininghaus to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This prevents that the setup of the PlacesItemModel \
queries Solid for the available devices, which can take some time.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Places can be added multiple times now using the context menu, but this has \
always been possible with drag and drop anyway.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
https://forum.kde.org/viewtopic.php?f=223&t=130617 for a dicsussion on this \
topic.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "Add to Places" entry is always enabled now in the \
context menu. I never observed a noticeable delay when right-clicking folders, but I \
am confident that this change removes the delay for the users who saw it.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphincontextmenu.cpp <span style="color: grey">(af283cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126904/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7059434412739120545==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic