[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123253: dolphin: Navigate to parent folder selects child folder
From: Gregor Mi <codestruct () posteo ! org>
Date: 2016-01-29 19:55:31
Message-ID: 20160129195531.17778.71560 () mimi ! kde ! org
[Download RAW message or body]
--===============2048490079700642237==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 29, 2016, 3:24 p.m., Frank Reininghaus wrote:
> > What I still do not understand is why you want to make this change in Dolphin, \
> > and not in KUrlNavigator, as I have suggested in another comment here some time \
> > ago.
> > Your patch will make the "go up" behavior inconsistent in Dolphin and the file \
> > dialog, which is rather bad for the user experience IMHO. If you change \
> > KUrlNavigator, then everything will be consistent, and code maintenance will be \
> > easier. Moreover, the risk of subtle bugs (by the two layers of history handling \
> > which your patch introduces) will be lower.
Hi, in some earlier comments I noted that I had difficulties implementing this in \
KUrlNavigator (can't remember why excactly, but I could look it up later).
I share your concern with the inconsistency issue between dolphin and file dialog. \
Right now, I see this as a lower priority because...
1) it was not sure if the feature was accepted at all and I wanted to present a \
working implementation. 2) I think most non-power users won't notice the feature at \
all. 3) In my personal experience "heavy-duty" navigating takes place in dolphin but \
not in the file dialog. So, the lack of the feature there would not be that bad.
That said, I think it should indeed be moved to KUrlNavigator or some other shared \
location to make the behaviour consistent, if time proves that the new behaviour is \
good to keep.
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review91783
-----------------------------------------------------------
On Jan. 24, 2016, 4:14 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 4:14 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Bugs: 335616
> https://bugs.kde.org/show_bug.cgi?id=335616
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This is a first working implementation of the feature suggestion filed in the \
> ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent \
> folder selects child folder".
> In short, this is what is does: Whenever the dolphin view is initialized to show \
> the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL \
> is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If \
> the check is successful, then the common child (in this example: \
> "/home/x/test/documents/") folder item will be selected and scrolled into view.
>
> Diffs
> -----
>
> src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7
> src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe
> src/tests/CMakeLists.txt 22a8b48491fa7ac88ce1b29aecb20192837dd7ea
> src/tests/urlutiltest.cpp PRE-CREATION
> src/urlutil.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
>
>
> Testing
> -------
>
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item \
> view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, \
> Alt+up, Backspace
>
> Thanks,
>
> Gregor Mi
>
>
--===============2048490079700642237==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123253/">https://git.reviewboard.kde.org/r/123253/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 29th, 2016, 3:24 p.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What I still do not understand is why you want to make \
this change in Dolphin, and not in KUrlNavigator, as I have suggested in another \
comment here some time ago.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Your patch will make the "go up" \
behavior inconsistent in Dolphin and the file dialog, which is rather bad for the \
user experience IMHO. If you change KUrlNavigator, then everything will be \
consistent, and code maintenance will be easier. Moreover, the risk of subtle bugs \
(by the two layers of history handling which your patch introduces) will be \
lower.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, \
in some earlier comments I noted that I had difficulties implementing this in \
KUrlNavigator (can't remember why excactly, but I could look it up later).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I share your concern with the inconsistency issue between dolphin and file \
dialog. Right now, I see this as a lower priority because...</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) it \
was not sure if the feature was accepted at all and I wanted to present a working \
implementation. 2) I think most non-power users won't notice the feature at all.
3) In my personal experience "heavy-duty" navigating takes place in dolphin but not \
in the file dialog. So, the lack of the feature there would not be that bad. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That said, I think it should indeed be moved to KUrlNavigator or some other \
shared location to make the behaviour consistent, if time proves that the new \
behaviour is good to keep.</p></pre> <br />
<p>- Gregor</p>
<br />
<p>On January 24th, 2016, 4:14 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 4:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335616">335616</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a first working implementation of the feature \
suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: \
Navigate to parent folder selects child folder".</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
short, this is what is does: Whenever the dolphin view is initialized to show the \
contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a \
parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the \
check is successful, then the common child (in this example: \
"/home/x/test/documents/") folder item will be selected and scrolled into \
view.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">unit test passes</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Played around with dolphin: enter URL manually, \
navigate via click in the item view, navigate via click in kurlnavigator, navigate \
with Alt+Left, Alt+Right, Alt+up, Backspace</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinviewcontainer.h <span style="color: \
grey">(62f91100e9e5d457edd6f4d927c87610335834d7)</span></li>
<li>src/dolphinviewcontainer.cpp <span style="color: \
grey">(8fea3ba9d0bb8389d89724b9f0cd74605c0286fe)</span></li>
<li>src/tests/CMakeLists.txt <span style="color: \
grey">(22a8b48491fa7ac88ce1b29aecb20192837dd7ea)</span></li>
<li>src/tests/urlutiltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlutil.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2048490079700642237==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic