[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123253: dolphin: Navigate to parent folder selects child folder
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2016-01-28 21:04:36
Message-ID: 20160128210436.17778.31284 () mimi ! kde ! org
[Download RAW message or body]
--===============6611544483339207715==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 19, 2015, 12:20 p.m., Emmanuel Pescosta wrote:
> > src/urlutil.h, line 25
> > <https://git.reviewboard.kde.org/r/123253/diff/1/?file=360008#file360008line25>
> >
> > use a namespace instead of a class
> >
> > but ... maybe we can move firstChildUrl to global.h/.cpp?
>
> Gregor Mi wrote:
> I thought "global.h/.cpp" kind of classes tend to blow up. Interestingly global.h \
> contains only two methods which are also URL related: validateUris and homeUrl. So \
> what about moving those to urlutil.h?
> Gregor Mi wrote:
> Which namespace should I choose (Dolphin or UrlUtil)? Or really move it to \
> global.*?
> So what about moving those to urlutil.h?
Good idea. Should be an extra patch ;)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review88587
-----------------------------------------------------------
On Jan. 24, 2016, 5:14 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 5:14 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Bugs: 335616
> https://bugs.kde.org/show_bug.cgi?id=335616
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This is a first working implementation of the feature suggestion filed in the \
> ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent \
> folder selects child folder".
> In short, this is what is does: Whenever the dolphin view is initialized to show \
> the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL \
> is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If \
> the check is successful, then the common child (in this example: \
> "/home/x/test/documents/") folder item will be selected and scrolled into view.
>
> Diffs
> -----
>
> src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7
> src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe
> src/tests/CMakeLists.txt 22a8b48491fa7ac88ce1b29aecb20192837dd7ea
> src/tests/urlutiltest.cpp PRE-CREATION
> src/urlutil.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
>
>
> Testing
> -------
>
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item \
> view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, \
> Alt+up, Backspace
>
> Thanks,
>
> Gregor Mi
>
>
--===============6611544483339207715==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123253/">https://git.reviewboard.kde.org/r/123253/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 19th, 2015, 12:20 p.m. CET, \
<b>Emmanuel Pescosta</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table class="sidebyside diff-error"
id="file360008">
<colgroup>
<col class="left" />
<col class="right" />
</colgroup>
<thead>
<tr class="filename-row">
<th colspan="2" class="filename">
<a href="/r/123253/diff/1/?file=360008#file360008line25">src/urlutil.h</a>
<span class="diffrevision">
(Diff revision 1)
</span>
</tr>
</thead>
<tbody>
<tr>
<td colspan="2">
<h2>
<div class="rb-icon rb-icon-warning"></div>
There was an error displaying this diff.
</h2>
<p>list index out of range</p>
<p>
This may be a bug in the software, a temporary outage, or an issue
with the format of your diff.
</p>
<p>
Please try again, and if you still have trouble,
<a href="/support/">contact support</a>.
</p>
</td>
</tr>
<tr>
<td colspan="2">
<a id="diff-error-link-360008-62660" href="#"
onclick="$('#diff-error-details-360008-62660').toggle(); return \
false;">Details</a> </td>
</tr>
<tr class="error-details" id="diff-error-details-360008-62660">
<td colspan="2">
<pre>Traceback (most recent call last):
File "/srv/www/reviewboard/virtualenv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/reviews/views.py", \
line 179, in build_diff_comment_fragments comment.interfilediff)
File "/srv/www/reviewboard/virtualenv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py", \
line 492, in get_last_line_number_in_diff last_chunk = f['chunks'][-1]
IndexError: list index out of range
</pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use a \
namespace instead of a class</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">but ... maybe we can move firstChildUrl \
to global.h/.cpp?</p></pre> </blockquote>
<p>On January 24th, 2016, 3:38 p.m. CET, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
thought "global.h/.cpp" kind of classes tend to blow up. Interestingly global.h \
contains only two methods which are also URL related: validateUris and homeUrl. So \
what about moving those to urlutil.h?</p></pre> </blockquote>
<p>On January 24th, 2016, 5:19 p.m. CET, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Which \
namespace should I choose (Dolphin or UrlUtil)? Or really move it to \
global.*?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> So \
what about moving those to urlutil.h?
Good idea. Should be an extra patch ;)</pre>
<br />
<p>- Emmanuel</p>
<br />
<p>On January 24th, 2016, 5:14 p.m. CET, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 5:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335616">335616</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a first working implementation of the feature \
suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: \
Navigate to parent folder selects child folder".</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
short, this is what is does: Whenever the dolphin view is initialized to show the \
contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a \
parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the \
check is successful, then the common child (in this example: \
"/home/x/test/documents/") folder item will be selected and scrolled into \
view.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">unit test passes</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Played around with dolphin: enter URL manually, \
navigate via click in the item view, navigate via click in kurlnavigator, navigate \
with Alt+Left, Alt+Right, Alt+up, Backspace</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinviewcontainer.h <span style="color: \
grey">(62f91100e9e5d457edd6f4d927c87610335834d7)</span></li>
<li>src/dolphinviewcontainer.cpp <span style="color: \
grey">(8fea3ba9d0bb8389d89724b9f0cd74605c0286fe)</span></li>
<li>src/tests/CMakeLists.txt <span style="color: \
grey">(22a8b48491fa7ac88ce1b29aecb20192837dd7ea)</span></li>
<li>src/tests/urlutiltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlutil.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6611544483339207715==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic