[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123253: dolphin: Navigate to parent folder selects child folder
From: Gregor Mi <codestruct () posteo ! org>
Date: 2016-01-24 16:14:29
Message-ID: 20160124161429.17849.84883 () mimi ! kde ! org
[Download RAW message or body]
--===============3905559624232581265==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 4:14 p.m.)
Review request for Dolphin and Emmanuel Pescosta.
Changes
-------
Fixed the following issues:
- remove or add a proper debug output (qCDebug)
- auto -> QUrl and constify
- remove spaces after { and before }
- add a nicer documentation instead of showing test cases
- add a new test
- commented on maybe we can move firstChildUrl to global.h/.cpp
- optimize actual code by removing the loop
Bugs: 335616
https://bugs.kde.org/show_bug.cgi?id=335616
Repository: dolphin
Description
-------
This is a first working implementation of the feature suggestion filed in the ticket \
https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder \
selects child folder".
In short, this is what is does: Whenever the dolphin view is initialized to show the \
contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a \
parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the \
check is successful, then the common child (in this example: \
"/home/x/test/documents/") folder item will be selected and scrolled into view.
Diffs (updated)
-----
src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7
src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe
src/tests/CMakeLists.txt 22a8b48491fa7ac88ce1b29aecb20192837dd7ea
src/tests/urlutiltest.cpp PRE-CREATION
src/urlutil.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123253/diff/
Testing
-------
- unit test passes
- Played around with dolphin: enter URL manually, navigate via click in the item \
view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, \
Backspace
Thanks,
Gregor Mi
--===============3905559624232581265==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123253/">https://git.reviewboard.kde.org/r/123253/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 4:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed the following issues:
- remove or add a proper debug output (qCDebug)
- auto -> QUrl and constify
- remove spaces after { and before }
- add a nicer documentation instead of showing test cases
- add a new test
- commented on maybe we can move firstChildUrl to global.h/.cpp
- optimize actual code by removing the loop</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335616">335616</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a first working implementation of the feature \
suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: \
Navigate to parent folder selects child folder".</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
short, this is what is does: Whenever the dolphin view is initialized to show the \
contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a \
parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the \
check is successful, then the common child (in this example: \
"/home/x/test/documents/") folder item will be selected and scrolled into \
view.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">unit test passes</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Played around with dolphin: enter URL manually, \
navigate via click in the item view, navigate via click in kurlnavigator, navigate \
with Alt+Left, Alt+Right, Alt+up, Backspace</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinviewcontainer.h <span style="color: \
grey">(62f91100e9e5d457edd6f4d927c87610335834d7)</span></li>
<li>src/dolphinviewcontainer.cpp <span style="color: \
grey">(8fea3ba9d0bb8389d89724b9f0cd74605c0286fe)</span></li>
<li>src/tests/CMakeLists.txt <span style="color: \
grey">(22a8b48491fa7ac88ce1b29aecb20192837dd7ea)</span></li>
<li>src/tests/urlutiltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlutil.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3905559624232581265==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic