[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 126718: Take into account QApplication::wheelScrollLines() in mouse wheel events
From:       "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date:       2016-01-13 17:02:42
Message-ID: 20160113170242.23702.7237 () mimi ! kde ! org
[Download RAW message or body]

--===============6338129250532997165==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126718/#review91024
-----------------------------------------------------------


Fixed bug 295571

- Emmanuel Pescosta


On Jan. 12, 2016, 2:03 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126718/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 2:03 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> when setting a different "mouse wheel scrolls by" value in the mouse kcm, the user \
> expects every view to scroll more or less accordingly (even if it's not strictlya \
> text view) This makes the scroll in dolphin take that into account
> 
> 
> Diffs
> -----
> 
> src/kitemviews/kitemlistcontainer.cpp c9d521c 
> src/kitemviews/private/kitemlistsmoothscroller.cpp 2bd467a 
> 
> Diff: https://git.reviewboard.kde.org/r/126718/diff/
> 
> 
> Testing
> -------
> 
> with the default value (3) it should scroll with more or less the same speed it \
> used to have 
> 
> Thanks,
> 
> Marco Martin
> 
> 


--===============6338129250532997165==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126718/">https://git.reviewboard.kde.org/r/126718/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed \
bug 295571</p></pre>  <br />









<p>- Emmanuel Pescosta</p>


<br />
<p>On January 12th, 2016, 2:03 p.m. CET, Marco Martin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin.</div>
<div>By Marco Martin.</div>


<p style="color: grey;"><i>Updated Jan. 12, 2016, 2:03 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">when setting a different "mouse wheel scrolls by" \
value in the mouse kcm, the user expects every view to scroll more or less \
accordingly (even if it's not strictlya text view) This makes the scroll in dolphin \
take that into account</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with the default value (3) it should scroll with more \
or less the same speed it used to have</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kitemviews/kitemlistcontainer.cpp <span style="color: \
grey">(c9d521c)</span></li>

 <li>src/kitemviews/private/kitemlistsmoothscroller.cpp <span style="color: \
grey">(2bd467a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126718/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============6338129250532997165==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic