'Re: Review Request 126693: Fix crash when clicking "Configure Dolphin..." in the control menu while '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 126693: Fix crash when clicking "Configure Dolphin..." in the control menu while 
From:       "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date:       2016-01-12 10:58:06
Message-ID: 20160112105806.23702.25053 () mimi ! kde ! org
[Download RAW message or body]

--===============3000614554476269898==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126693/#review90962
-----------------------------------------------------------

Ship it!


Thanks! Good catch! :)

- Emmanuel Pescosta


On Jan. 10, 2016, 11:28 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126693/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 11:28 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 354558
> https://bugs.kde.org/show_bug.cgi?id=354558
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Do not delete sub menus of the control menu explicitly
> 
> This is not necessary because the sub menus are children of the main menu, such \
> that they are deleted together with the other actions by QMenu::clear(). 
> This prevents a crash that can happen if a sub menu is open while another menu \
> action is clicked. 
> Thanks to Fabian Vogt and Wolfgang Bauer for investigating this issue!
> 
> BUG: 354558
> FIXED-IN: 15.12.2
> 
> 
> Diffs
> -----
> 
> src/dolphinmainwindow.cpp 9b05168 
> 
> Diff: https://git.reviewboard.kde.org/r/126693/diff/
> 
> 
> Testing
> -------
> 
> Verified that the crash is not reproducible any more, and checked with Valgrind \
> that this does not cause any memory leaks. 
> 
> Thanks,
> 
> Frank Reininghaus
> 
> 


--===============3000614554476269898==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126693/">https://git.reviewboard.kde.org/r/126693/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks! Good catch! :)</p></pre>  <br />









<p>- Emmanuel Pescosta</p>


<br />
<p>On January 10th, 2016, 11:28 a.m. CET, Frank Reininghaus wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>


<p style="color: grey;"><i>Updated Jan. 10, 2016, 11:28 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=354558">354558</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not delete sub menus of the control menu explicitly  
This is not necessary because the sub menus are children of the main menu, such that \
they are deleted together with the other actions by QMenu::clear().  
This prevents a crash that can happen if a sub menu is open while another menu action \
is clicked.  
Thanks to Fabian Vogt and Wolfgang Bauer for investigating this issue!
    
BUG: 354558
FIXED-IN: 15.12.2</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Verified that the crash is not reproducible any more, \
and checked with Valgrind that this does not cause any memory leaks.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dolphinmainwindow.cpp <span style="color: grey">(9b05168)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126693/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============3000614554476269898==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic