[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123253: dolphin: Navigate to parent folder selects child folder
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2015-04-17 15:35:27
Message-ID: 20150417153527.5926.4073 () mimi ! kde ! org
[Download RAW message or body]
--===============7928756540165937952==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review79134
-----------------------------------------------------------
Thanks for your detailed reply! I'm still not quite convinced that the proposed \
behavior is what most users would expect. If I'm in a subfolder somewhere in the \
/usr/include hierarchy, and then I enter /usr/include in the location bar, then I \
want to see the first subfolders of /usr/include (i.e., the view scrolled to the \
top). Seeing the view scrolled down to a folder which happens to be an indirect \
parent of the previous folder would surprise me.
But even if we assume that many users would like the feature, then I see the risk \
that there will be bugs in the future because the history handling of KUrlNavigator \
and the "last URL" handling in DolphinViewContainer might interact in unexpected \
ways.
I think that changing KUrlNavigator such that interprets "up" as "back" if it seems \
appropriate (or that it creates a new history entry, but copies the view state data \
from the "back" entry - I don't know what's better) is less dangerous and would solve \
most problems that users currently see with the "up" behavior.
I have expressed all my thoughts on this issue in detail now - I'm curious what \
others think! And in any case, I appreciate all the effort you put into making KDE \
better :-)
- Frank Reininghaus
On April 4, 2015, 1:17 nachm., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
>
> (Updated April 4, 2015, 1:17 nachm.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This is a first working implementation of the feature suggestion filed in the \
> ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent \
> folder selects child folder".
> In short, this is what is does: Whenever the dolphin view is initialized to show \
> the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL \
> is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If \
> the check is successful, then the common child (in this example: \
> "/home/x/test/documents/") folder item will be selected and scrolled into view.
>
> Diffs
> -----
>
> src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7
> src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe
> src/tests/kfileitemmodeltest.cpp eba32e1e1caa341e1db26399b4027a86614309fc
> src/urlutil.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
>
>
> Testing
> -------
>
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item \
> view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, \
> Alt+up, Backspace
>
> Thanks,
>
> Gregor Mi
>
>
--===============7928756540165937952==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123253/">https://git.reviewboard.kde.org/r/123253/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for your detailed reply! I'm still not quite convinced that the \
proposed behavior is what most users would expect. If I'm in a subfolder somewhere in \
the /usr/include hierarchy, and then I enter /usr/include in the location bar, then I \
want to see the first subfolders of /usr/include (i.e., the view scrolled to the \
top). Seeing the view scrolled down to a folder which happens to be an indirect \
parent of the previous folder would surprise me.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
even if we assume that many users would like the feature, then I see the risk that \
there will be bugs in the future because the history handling of KUrlNavigator and \
the "last URL" handling in DolphinViewContainer might interact in unexpected \
ways.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think that changing KUrlNavigator such that \
interprets "up" as "back" if it seems appropriate (or that it creates a new history \
entry, but copies the view state data from the "back" entry - I don't know what's \
better) is less dangerous and would solve most problems that users currently see with \
the "up" behavior.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I have expressed all my thoughts on \
this issue in detail now - I'm curious what others think! And in any case, I \
appreciate all the effort you put into making KDE better :-)</p></pre> <br />
<p>- Frank Reininghaus</p>
<br />
<p>On April 4th, 2015, 1:17 nachm. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 4, 2015, 1:17 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a first working implementation of the feature \
suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: \
Navigate to parent folder selects child folder".</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
short, this is what is does: Whenever the dolphin view is initialized to show the \
contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a \
parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the \
check is successful, then the common child (in this example: \
"/home/x/test/documents/") folder item will be selected and scrolled into \
view.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">unit test passes</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Played around with dolphin: enter URL manually, \
navigate via click in the item view, navigate via click in kurlnavigator, navigate \
with Alt+Left, Alt+Right, Alt+up, Backspace</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinviewcontainer.h <span style="color: \
grey">(62f91100e9e5d457edd6f4d927c87610335834d7)</span></li>
<li>src/dolphinviewcontainer.cpp <span style="color: \
grey">(8fea3ba9d0bb8389d89724b9f0cd74605c0286fe)</span></li>
<li>src/tests/kfileitemmodeltest.cpp <span style="color: \
grey">(eba32e1e1caa341e1db26399b4027a86614309fc)</span></li>
<li>src/urlutil.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7928756540165937952==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic