[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 123080: Save bookmarks when adding them via the context menu
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2015-03-21 11:23:01
Message-ID: 20150321112301.3832.426 () mimi ! kde ! org
[Download RAW message or body]
--===============1664923018312025780==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123080/#review77872
-----------------------------------------------------------
Ship it!
Looks good!
Encapsulating the access to the bookmarks file is probably a good idea. Whenenver I \
had to work with the "Places" code, I also thought that having a wrapper class (maybe \
in KIO?) that provides a simple API to manipulate the "Places" would be great.
- Frank Reininghaus
On März 20, 2015, 11:02 vorm., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123080/
> -----------------------------------------------------------
>
> (Updated März 20, 2015, 11:02 vorm.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 345347
> http://bugs.kde.org/show_bug.cgi?id=345347
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Save bookmarks when adding them via the context menu.
>
> We have to call PlacesItemModel::saveBookmarks explicitly since \
> https://git.reviewboard.kde.org/r/122640/ Maybe we should create a bookmarks \
> service in future to encapsulate it.
> FIXED-IN: 15.04
> BUG: 345347
>
>
> Diffs
> -----
>
> dolphin/src/dolphincontextmenu.cpp e692c8f
>
> Diff: https://git.reviewboard.kde.org/r/123080/diff/
>
>
> Testing
> -------
>
> "Add to places" works in the item and viewport context menu
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============1664923018312025780==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123080/">https://git.reviewboard.kde.org/r/123080/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Encapsulating the access to the bookmarks file is \
probably a good idea. Whenenver I had to work with the "Places" code, I also thought \
that having a wrapper class (maybe in KIO?) that provides a simple API to manipulate \
the "Places" would be great.</p></pre> <br />
<p>- Frank Reininghaus</p>
<br />
<p>On März 20th, 2015, 11:02 vorm. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated März 20, 2015, 11:02 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345347">345347</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Save bookmarks when adding them via the context \
menu.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We have to call PlacesItemModel::saveBookmarks \
explicitly since https://git.reviewboard.kde.org/r/122640/ Maybe we should create a \
bookmarks service in future to encapsulate it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">FIXED-IN: 15.04
BUG: 345347</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">"Add to places" works in the item and viewport context \
menu</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(e692c8f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123080/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1664923018312025780==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic