[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 122631: Make the FoldersPanel work again
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2015-02-19 20:32:34
Message-ID: 20150219203234.4988.30293 () probe ! kde ! org
[Download RAW message or body]
--===============2613520970356599301==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122631/#review76310
-----------------------------------------------------------
Good catch :-)
I think that the QT_NO_URL_CAST_FROM_STRING idea is very good. It's possible that \
there are a few more bugs of this kind.
- Frank Reininghaus
On Feb. 19, 2015, 11:11 vorm., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122631/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 11:11 vorm.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 344204
> http://bugs.kde.org/show_bug.cgi?id=344204
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> QUrl porting bug: Added a missing QUrl::fromLocalFile in FoldersPanel::loadTree to \
> make the FoldersPanel work again
> PS: Maybe we should remove the "remove_definitions(-DQT_NO_URL_CAST_FROM_STRING)" \
> from cmake to avoid such problems in future :/
>
> Diffs
> -----
>
> dolphin/src/panels/folders/folderspanel.cpp b83e950
>
> Diff: https://git.reviewboard.kde.org/r/122631/diff/
>
>
> Testing
> -------
>
> Works, tested with local and remote locations
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============2613520970356599301==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122631/">https://git.reviewboard.kde.org/r/122631/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good \
catch :-)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think that the QT_NO_URL_CAST_FROM_STRING idea is \
very good. It's possible that there are a few more bugs of this kind.</p></pre> <br \
/>
<p>- Frank Reininghaus</p>
<br />
<p>On Februar 19th, 2015, 11:11 vorm. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2015, 11:11 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=344204">344204</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QUrl porting bug: Added a missing QUrl::fromLocalFile in \
FoldersPanel::loadTree to make the FoldersPanel work again
PS: Maybe we should remove the \
"remove_definitions(-DQT_NO_URL_CAST_FROM_STRING)" from cmake to avoid such \
problems in future :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works, tested with local and remote \
locations</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(b83e950)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122631/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2613520970356599301==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic