[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 121087: Use deleteLater() to delete the selection toggle in KItemListWidget::slot
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-11-09 18:40:42
Message-ID: 20141109184042.2122.67638 () probe ! kde ! org
[Download RAW message or body]
--===============3815746561495697019==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121087/#review70123
-----------------------------------------------------------
> doesn't make anything worse.
There is one subtle difference between delete and deleteLater, though, which indeed might make \
things worse: only delete is save to be called on a null ptr.
- Christoph Feck
On Nov. 9, 2014, 5:11 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121087/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2014, 5:11 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 334785
> http://bugs.kde.org/show_bug.cgi?id=334785
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> This patch should make a crash with a backtrace as provided in the bug report impossible. I'm \
> not sure if this would really prevent the crash - it looks like the actual cause of the \
> problem could be in QGraphicsView or anywhere else. But I'm pretty sure that this change \
> doesn't make anything worse.
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistwidget.cpp e7d2951
>
> Diff: https://git.reviewboard.kde.org/r/121087/diff/
>
>
> Testing
> -------
>
> Hovering and un-hovering icons and selection toggles works as before.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
--===============3815746561495697019==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121087/">https://git.reviewboard.kde.org/r/121087/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 \
0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">doesn't make anything worse.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There is one subtle difference between delete and deleteLater, though, which indeed \
might make things worse: only delete is save to be called on a null ptr.</p></pre> <br />
<p>- Christoph Feck</p>
<br />
<p>On November 9th, 2014, 5:11 p.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2014, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334785">334785</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch \
should make a crash with a backtrace as provided in the bug report impossible. I'm not sure if \
this would really prevent the crash - it looks like the actual cause of the problem could be in \
QGraphicsView or anywhere else. But I'm pretty sure that this change doesn't make anything \
worse.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hovering and \
un-hovering icons and selection toggles works as before.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistwidget.cpp <span style="color: grey">(e7d2951)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121087/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3815746561495697019==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic