[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 112589: Use the Nepomuk Query Builder widget to add syntax-highlighting in Dolphi
From: "Denis Steckelmacher" <steckdenis () yahoo ! fr>
Date: 2014-09-09 17:09:46
Message-ID: 20140909170946.8755.72252 () probe ! kde ! org
[Download RAW message or body]
--===============1458185851612542932==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112589/
-----------------------------------------------------------
(Updated Sept. 9, 2014, 5:09 p.m.)
Review request for Dolphin.
Changes
-------
Cleanup unused includes and forward declarations, and use the new signal/slot syntax
Repository: kde-baseapps
Description
-------
When Dolphin is compiled with Nepomuk support, this patch replaces the plain line \
edit in which the user enters a search query with the new auto-completed QueryBuilder \
widget.
The user interface of the widget is shown in \
http://steckdenis.be/static/images/dolphin-query-builder.png .
The QueryBuilder widget can be found in the "steckdenis-gsoc2013" branch of \
nepomuk-widgets. You will also need the "steckdenis-gsoc2013" branch of nepomuk-core. \
This patch is not yet ready for merging as we have to wait that my other branches get \
merged in nepomuk-core and nepomuk-widgets. Some small changes in the API of the \
QueryBuilder are still possible.
Diffs (updated)
-----
dolphin/src/search/dolphinsearchbox.h 53b12ff
dolphin/src/search/dolphinsearchbox.cpp ae93030
dolphin/src/CMakeLists.txt fec365a
Diff: https://git.reviewboard.kde.org/r/112589/diff/
Testing
-------
Compiling with the CMake variable WITH_NepomukWidgets set to ON is possible and the \
resulting Dolphin works as expected (the query builder widget is displayed and \
queries can be entered in it). When this variable is set to OFF, Dolphin still builds \
and runs correctly, except that there is no auto-completion available.
The only problem is that even without the patch (and Nepomuk enabled system-wide and \
at compile time), Dolphin does not seem to use Nepomuk queries. Every search \
operation is slow and there is a huge amount of disk activity. Nepomuk queries like \
"modified last week" work perfectly well in KRunner. This problem (likely due to a \
misconfiguration on my desktop as it is present in Dolphin master and Dolphin 4.11, \
with Nepomuk-Core master or 4.11) prevents me from testing that queries entered in \
the query builder actually work. Can somebody with a working dolphin test that ?
Thanks,
Denis Steckelmacher
--===============1458185851612542932==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112589/">https://git.reviewboard.kde.org/r/112589/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2014, 5:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cleanup unused includes and forward declarations, and use the new \
signal/slot syntax</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When Dolphin is compiled with Nepomuk support, this \
patch replaces the plain line edit in which the user enters a search query with the \
new auto-completed QueryBuilder widget.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The user interface of \
the widget is shown in http://steckdenis.be/static/images/dolphin-query-builder.png \
.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The QueryBuilder widget can be found in the \
"steckdenis-gsoc2013" branch of nepomuk-widgets. You will also need the \
"steckdenis-gsoc2013" branch of nepomuk-core. This patch is not yet ready for merging \
as we have to wait that my other branches get merged in nepomuk-core and \
nepomuk-widgets. Some small changes in the API of the QueryBuilder are still \
possible.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiling with the CMake variable WITH_NepomukWidgets \
set to ON is possible and the resulting Dolphin works as expected (the query builder \
widget is displayed and queries can be entered in it). When this variable is set to \
OFF, Dolphin still builds and runs correctly, except that there is no auto-completion \
available.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The only problem is that even without the patch (and \
Nepomuk enabled system-wide and at compile time), Dolphin does not seem to use \
Nepomuk queries. Every search operation is slow and there is a huge amount of disk \
activity. Nepomuk queries like "modified last week" work perfectly well in KRunner. \
This problem (likely due to a misconfiguration on my desktop as it is present in \
Dolphin master and Dolphin 4.11, with Nepomuk-Core master or 4.11) prevents me from \
testing that queries entered in the query builder actually work. Can somebody with a \
working dolphin test that ?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/search/dolphinsearchbox.h <span style="color: \
grey">(53b12ff)</span></li>
<li>dolphin/src/search/dolphinsearchbox.cpp <span style="color: \
grey">(ae93030)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(fec365a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112589/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1458185851612542932==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic