[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 110133: Add "Open Path" context menu action
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-09-09 13:40:06
Message-ID: 20140909134006.8755.15005 () probe ! kde ! org
[Download RAW message or body]

--===============4983658805354361474==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110133/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 1:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Repository: kde-baseapps


Description
-------

As I'm not a particular fan of tabbed browsing (at least not in a file manager), I \
need a "Open Path" action that does neither open a new tab nor a new window. This \
patch adds this option.


Diffs
-----

  dolphin/src/dolphincontextmenu.h 180f917 
  dolphin/src/dolphincontextmenu.cpp 22272fb 
  dolphin/src/dolphinmainwindow.cpp 21d1320 

Diff: https://git.reviewboard.kde.org/r/110133/diff/


Testing
-------

Tested with normal and split view. Works :-)


File Attachments
----------------

Context menu entry
  https://git.reviewboard.kde.org/media/uploaded/files/2013/04/23/openpath.png


Thanks,

Kai Uwe Broulik


--===============4983658805354361474==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110133/">https://git.reviewboard.kde.org/r/110133/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Sept. 9, 2014, 1:40 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As I'm not a particular fan of tabbed browsing (at \
least not in a file manager), I need a "Open Path" action that does neither open a \
new tab nor a new window. This patch adds this option.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with normal and split view. Works :-)</p></pre> \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphincontextmenu.h <span style="color: grey">(180f917)</span></li>

 <li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(22272fb)</span></li>

 <li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(21d1320)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110133/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/04/23/openpath.png">Context \
menu entry</a></li>

</ul>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============4983658805354361474==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic