[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113957: Rename of "Recently Accessed" to "Recently Saved"
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-09-07 7:51:57
Message-ID: 20140907075157.8756.6594 () probe ! kde ! org
[Download RAW message or body]
--===============5429440592449559540==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113957/#review65945
-----------------------------------------------------------
We should close this review request, because this problem has been fixed by \
https://git.reviewboard.kde.org/r/119986/
- Emmanuel Pescosta
On Dec. 8, 2013, 11:39 p.m., Richard llom wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113957/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2013, 11:39 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Bugs: 304854
> http://bugs.kde.org/show_bug.cgi?id=304854
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> This is a diff for the dolphin places bar, which renames "Recently Accessed" to \
> "Recently Saved" in the naming and in the code comments - as discussed in \
> https://bugs.kde.org/show_bug.cgi?id=304854 .
>
> Diffs
> -----
>
> dolphin/src/panels/places/placesitem.h 297f12d
> dolphin/src/panels/places/placesitem.cpp 41f22cc
> dolphin/src/panels/places/placesitemmodel.cpp 681479d
> dolphin/src/panels/places/placespanel.cpp d5308ea
>
> Diff: https://git.reviewboard.kde.org/r/113957/diff/
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Richard llom
>
>
--===============5429440592449559540==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113957/">https://git.reviewboard.kde.org/r/113957/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
should close this review request, because this problem has been fixed by \
https://git.reviewboard.kde.org/r/119986/</p></pre> <br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On December 8th, 2013, 11:39 p.m. CET, Richard llom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Richard llom.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2013, 11:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304854">304854</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a diff for the dolphin places bar, which renames "Recently \
Accessed" to "Recently Saved" in the naming and in the code comments - \
as discussed in https://bugs.kde.org/show_bug.cgi?id=304854 .</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/places/placesitem.h <span style="color: \
grey">(297f12d)</span></li>
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(41f22cc)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(681479d)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(d5308ea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113957/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5429440592449559540==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic