From kfm-devel Fri Sep 05 08:25:34 2014 From: "Emmanuel Pescosta" Date: Fri, 05 Sep 2014 08:25:34 +0000 To: kfm-devel Subject: Re: Review Request 113957: Rename of "Recently Accessed" to "Recently Saved" Message-Id: <20140905082534.11809.48316 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=140990554832386 --===============4330894216865168262== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 4, 2014, 11:44 p.m., Xuetian Weng wrote: > > What about using "Recently Modified" instead of "Recently Saved"? IMHO it's more consistent with strings in other place, for example, dolphin file properties uses "Accessed" and "Modified". > > kdeuser 56 wrote: > I would have gone with "Recently Modified" too, but the usability concerns seems valid imho. Could you list the other places that still use Modified? We could rename them too. > > kdeuser 56 wrote: > Kpropertiesdialog does not seem to be part of dolphin, it is part of kdelibs, but we the question now is, should we rename "Modified" there to "Last Saved" or simply only "Saved", which is not as descriptive as "Modified" imho? > Kpropertiesdialog does not seem to be part of dolphin, it is part of kdelibs It is a part of KIO (KF5) > but we the question now is Great question, can you please start a new thread about this problem on the usability mailinglist (see https://mail.kde.org/mailman/listinfo/kde-usability)? Thanks in advance! :) - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113957/#review65813 ----------------------------------------------------------- On Dec. 8, 2013, 11:39 p.m., Richard llom wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113957/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2013, 11:39 p.m.) > > > Review request for Dolphin and Frank Reininghaus. > > > Bugs: 304854 > http://bugs.kde.org/show_bug.cgi?id=304854 > > > Repository: kde-baseapps > > > Description > ------- > > This is a diff for the dolphin places bar, which renames "Recently Accessed" to "Recently Saved" in the naming and in the code comments - as discussed in https://bugs.kde.org/show_bug.cgi?id=304854 . > > > Diffs > ----- > > dolphin/src/panels/places/placesitem.h 297f12d > dolphin/src/panels/places/placesitem.cpp 41f22cc > dolphin/src/panels/places/placesitemmodel.cpp 681479d > dolphin/src/panels/places/placespanel.cpp d5308ea > > Diff: https://git.reviewboard.kde.org/r/113957/diff/ > > > Testing > ------- > > No. > > > Thanks, > > Richard llom > > --===============4330894216865168262== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113957/

On September 4th, 2014, 11:44 p.m. CEST, Xuetian Weng wrote:

What about using "Recently Modified" instead of "Recently Saved"? IMHO it's more consistent with strings in other place, for example, dolphin file properties uses "Accessed" and "Modified".

On September 5th, 2014, 10:15 a.m. CEST, kdeuser 56 wrote:

I would have gone with "Recently Modified" too, but the usability concerns seems valid imho. Could you list the other places that still use Modified? We could rename them too.

On September 5th, 2014, 10:19 a.m. CEST, kdeuser 56 wrote:

Kpropertiesdialog does not seem to be part of dolphin, it is part of kdelibs, but we the question now is, should we rename "Modified" there to "Last Saved" or simply only "Saved", which is not as descriptive as "Modified" imho?


Kpropertiesdialog does not seem to be part of dolphin, it is part of kdelibs




It is a part of KIO (KF5)




but we the question now is




Great question, can you please start a new thread about this problem on the usability mailinglist (see https://mail.kde.org/mailman/listinfo/kde-usability)? Thanks in advance! :)

- Emmanuel


On December 8th, 2013, 11:39 p.m. CET, Richard llom wrote:

Review request for Dolphin and Frank Reininghaus.
By Richard llom.

Updated Dec. 8, 2013, 11:39 p.m.

Bugs: 304854
Repository: kde-baseapps

Description 

This is a diff for the dolphin places bar, which renames "Recently Accessed" to "Recently Saved" in the naming and in the code comments - as discussed in https://bugs.kde.org/show_bug.cgi?id=304854 .

Testing 

No.

Diffs

  • dolphin/src/panels/places/placesitem.h (297f12d)
  • dolphin/src/panels/places/placesitem.cpp (41f22cc)
  • dolphin/src/panels/places/placesitemmodel.cpp (681479d)
  • dolphin/src/panels/places/placespanel.cpp (d5308ea)

View Diff
--===============4330894216865168262==--