[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 119115: DolphinTabWidget
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-08-10 16:57:52
Message-ID: 20140810165752.12259.5558 () probe ! kde ! org
[Download RAW message or body]
--===============3946404707853506909==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/
-----------------------------------------------------------
(Updated Aug. 10, 2014, 4:57 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Bugs: 315904
http://bugs.kde.org/show_bug.cgi?id=315904
Repository: kde-baseapps
Description
-------
Implemented DolphinTabWidget class to encapsulate the tab handling from \
DolphinMainWindow.
Removed the method for text squeezing because the QTabBar can do this automatically.
The tab sizes are different, any idea how to fix this?
Diffs
-----
dolphin/src/dolphintabwidget.cpp PRE-CREATION
dolphin/src/CMakeLists.txt 7b0210a
dolphin/src/dolphinmainwindow.h 6f37f42
dolphin/src/dolphinmainwindow.cpp d321d3b
dolphin/src/dolphintabpage.h 95c02ed
dolphin/src/dolphintabpage.cpp 82be6d5
dolphin/src/dolphintabwidget.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119115/diff/
Testing
-------
Works great so far.
Thanks,
Emmanuel Pescosta
--===============3946404707853506909==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119115/">https://git.reviewboard.kde.org/r/119115/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2014, 4:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=315904">315904</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implemented DolphinTabWidget class to encapsulate the \
tab handling from DolphinMainWindow.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Removed the method for \
text squeezing because the QTabBar can do this automatically.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
tab sizes are different, any idea how to fix this?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works great so far.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphintabwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(7b0210a)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(6f37f42)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(d321d3b)</span></li>
<li>dolphin/src/dolphintabpage.h <span style="color: grey">(95c02ed)</span></li>
<li>dolphin/src/dolphintabpage.cpp <span style="color: grey">(82be6d5)</span></li>
<li>dolphin/src/dolphintabwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119115/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3946404707853506909==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic