--===============0892261879155714632== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 20, 2014, 11:45 p.m., Frank Reininghaus wrote: > > dolphin/src/dolphintabwidget.cpp, line 39 > > > > > > It seems that this signal does not exist either. QTabWidget signal, see http://qt-project.org/doc/qt-4.8/qtabwidget.html#currentChanged > On July 20, 2014, 11:45 p.m., Frank Reininghaus wrote: > > dolphin/src/dolphintabwidget.cpp, line 37 > > > > > > As far as I can see, this signal does not exist at all? QTabWidget signal, see http://qt-project.org/doc/qt-4.8/qtabwidget.html#tabCloseRequested - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119115/#review62752 ----------------------------------------------------------- On July 15, 2014, 11:26 p.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119115/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 11:26 p.m.) > > > Review request for Dolphin. > > > Repository: kde-baseapps > > > Description > ------- > > Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow. > > Removed the method for text squeezing because the QTabBar can do this automatically. > > The tab sizes are different, any idea how to fix this? > > > Diffs > ----- > > dolphin/src/CMakeLists.txt 7b0210a > dolphin/src/dolphinmainwindow.h 9c7f185 > dolphin/src/dolphinmainwindow.cpp 41bd626 > dolphin/src/dolphintabwidget.h PRE-CREATION > dolphin/src/dolphintabwidget.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119115/diff/ > > > Testing > ------- > > Works great so far. > > > Thanks, > > Emmanuel Pescosta > > --===============0892261879155714632== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119115/

On July 20th, 2014, 11:45 p.m. CEST, Frank Reininghaus wrote:
dolphin/src/dolphintabwidget.cpp (Diff revision 3)
37
    connect(this, SIGNAL(tabCloseRequested(int)),
As far as I can see, this signal does not exist at all?

QTabWidget signal, see http://qt-project.org/doc/qt-4.8/qtabwidget.html#tabCloseRequested

On July 20th, 2014, 11:45 p.m. CEST, Frank Reininghaus wrote:
dolphin/src/dolphintabwidget.cpp (Diff revision 3)
39
    connect(this, SIGNAL(currentChanged(int)),
It seems that this signal does not exist either.

QTabWidget signal, see http://qt-project.org/doc/qt-4.8/qtabwidget.html#currentChanged

- Emmanuel

On July 15th, 2014, 11:26 p.m. CEST, Emmanuel Pescosta wrote:

Review request for Dolphin.

By Emmanuel Pescosta.

Updated July 15, 2014, 11:26 p.m.

Repository: kde-baseapps

Description

Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
Removed the method for text squeezing because the QTabBar can do this automatically.
The tab sizes are different, any idea how to fix this?

Testing

Works great so far.

Diffs

dolphin/src/CMakeLists.txt (7b0210a)
dolphin/src/dolphinmainwindow.h (9c7f185)
dolphin/src/dolphinmainwindow.cpp (41bd626)
dolphin/src/dolphintabwidget.h (PRE-CREATION)
dolphin/src/dolphintabwidget.cpp (PRE-CREATION)

--===============0892261879155714632==--