From kfm-devel Wed Jul 23 11:07:04 2014 From: Olivier Goffart Date: Wed, 23 Jul 2014 11:07:04 +0000 To: kfm-devel Subject: Re: Overlay icons in Dolphin and Konqueror Message-Id: <3877506.52CRzoRfFN () finn> X-MARC-Message: https://marc.info/?l=kfm-devel&m=140611364315881 On Thursday 17 July 2014 19:55:23 Olivier Goffart wrote: > On Friday 04 July 2014 10:51:16 Olivier Goffart wrote: > > Hi, > > > > I am working with the ownCloud sync client. One of the feature we would > > like to have is to display overlay icons in the file managers. The icons > > should display the synchronization state, and more importantly the fact > > that folders are shared. > > > > As far as I could see, there is no interface in Konqueror or Dolphin to > > show arbitrary overlay icon. > > I am aware of KVersionControlPlugin (and we already have such a plugin), > > but it's interface is too limited, as only some possibilities are > > available, but we would like to display any kind of icons. > > > > I am then going to implement such interface. > > Where should it go? > > in a new KFileOverlayIconPlugin class? > > Should id go in kio (next KAbstractFileItemActionPlugin)? > > Or should it go in lib/konq next to KVersionControlPlugin? > > > > For the implementation, I believe I can base myself on the > > KVersionControlPlugin but returning an QIcon instead of state. > > Thanks Frank and David for your answer. > > I drafted some (working) work in progress. The patch is attached. > The prototype owncloud plugin is also attached (but the communication > protocol is not set in stone and is going to be only released in the next > version of the client) > So I can have feedback if I'm going in the right direction. > > I guess I'm too late with this to go into KDE SC 4.14? > So my next question is weather there would be another version of Dolphin > based on kdelibs, or if I should just go for the frameworks branch. > > (For some reason, the "shared" icon is suddenly a very important feature for > owncloud, and they would like to have it ASAP for the users now that > Owncloud 7 (the server) was released) > > > Please reply to all, I am not subscribed. Hi, Sorry to insist. I would like to have feedback on the patch to know if i'm going in the right direction. Also, in which branch should it go? -- Olivier