[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 119115: DolphinTabWidget
From:       "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date:       2014-07-15 21:26:05
Message-ID: 20140715212605.32551.41224 () probe ! kde ! org
[Download RAW message or body]

--===============8855127077645430780==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/
-----------------------------------------------------------

(Updated July 15, 2014, 11:26 p.m.)


Review request for Dolphin.


Changes
-------

Fixed all mentioned problems

Renamed openNewTab() slot to openNewActivatedTab() in DolphinTabWidget and in \
DolphinMainWindow so that the method name reflects the behaviour of this method.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabWidget class to encapsulate the tab handling from \
DolphinMainWindow.

Removed the method for text squeezing because the QTabBar can do this automatically.

The tab sizes are different, any idea how to fix this?


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt 7b0210a 
  dolphin/src/dolphinmainwindow.h 9c7f185 
  dolphin/src/dolphinmainwindow.cpp 41bd626 
  dolphin/src/dolphintabwidget.h PRE-CREATION 
  dolphin/src/dolphintabwidget.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119115/diff/


Testing
-------

Works great so far.


Thanks,

Emmanuel Pescosta


--===============8855127077645430780==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119115/">https://git.reviewboard.kde.org/r/119115/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>


<p style="color: grey;"><i>Updated July 15, 2014, 11:26 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed all mentioned problems

Renamed openNewTab() slot to openNewActivatedTab() in DolphinTabWidget and in \
DolphinMainWindow so that the method name reflects the behaviour of this \
method.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implemented DolphinTabWidget class to encapsulate the \
tab handling from DolphinMainWindow.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Removed the method for \
text squeezing because the QTabBar can do this automatically.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
tab sizes are different, any idea how to fix this?</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works great so far.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/CMakeLists.txt <span style="color: grey">(7b0210a)</span></li>

 <li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(9c7f185)</span></li>

 <li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(41bd626)</span></li>

 <li>dolphin/src/dolphintabwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>dolphin/src/dolphintabwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119115/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============8855127077645430780==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic