[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 119238: Fix the visibility of the "Places Selector" in the location bar
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-07-15 18:48:31
Message-ID: 20140715184831.32550.71535 () probe ! kde ! org
[Download RAW message or body]
--===============2663939925331802147==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119238/#review62417
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On July 12, 2014, 10:23 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119238/
> -----------------------------------------------------------
>
> (Updated July 12, 2014, 10:23 a.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 337389
> http://bugs.kde.org/show_bug.cgi?id=337389
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> The "Places Selector" at the front of the location bar should be shown if and only \
> if the Places Panel is hidden.
> Since https://git.reviewboard.kde.org/r/118964/, there are two problems with this \
> functionality:
> 1. In new tabs, the expected visibility of the selector is reversed.
>
> 2. When splitting the view, the selector is always shown in the new view.
>
> This patch fixes both problems.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 0c48928
> dolphin/src/dolphintabpage.cpp c8e4263
>
> Diff: https://git.reviewboard.kde.org/r/119238/diff/
>
>
> Testing
> -------
>
> I cannot reproduce the problems any more, and I have not found any new problems yet \
> so far.
>
> Thanks,
>
> Frank Reininghaus
>
>
--===============2663939925331802147==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119238/">https://git.reviewboard.kde.org/r/119238/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On July 12th, 2014, 10:23 a.m. CEST, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated July 12, 2014, 10:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337389">337389</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "Places Selector" at the front of the location bar \
should be shown if and only if the Places Panel is hidden.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since \
https://git.reviewboard.kde.org/r/118964/, there are two problems with this \
functionality:</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
new tabs, the expected visibility of the selector is reversed.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">When splitting the view, the selector \
is always shown in the new view.</p> </li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch fixes both problems.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I cannot reproduce the problems any more, and I have \
not found any new problems yet so far.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(0c48928)</span></li>
<li>dolphin/src/dolphintabpage.cpp <span style="color: grey">(c8e4263)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119238/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2663939925331802147==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic