[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 119115: DolphinTabWidget
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-07-09 21:03:53
Message-ID: 20140709210353.19519.39609 () probe ! kde ! org
[Download RAW message or body]
--===============5755832746424168863==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review62020
-----------------------------------------------------------
dolphin/src/dolphintabwidget.h
<https://git.reviewboard.kde.org/r/119115/#comment43150>
Maybe we should rename this method to openNewActivatedTab() here and in \
DolphinMainWindow?
We use this slot for opening new tabs with e.g. ctrl + T.
- Emmanuel Pescosta
On July 9, 2014, 10:40 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
>
> (Updated July 9, 2014, 10:40 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Implemented DolphinTabWidget class to encapsulate the tab handling from \
> DolphinMainWindow.
> Removed the method for text squeezing because the QTabBar can do this \
> automatically.
> The tab sizes are different, any idea how to fix this?
>
>
> Diffs
> -----
>
> dolphin/src/CMakeLists.txt 7b0210a
> dolphin/src/dolphinmainwindow.h 9c7f185
> dolphin/src/dolphinmainwindow.cpp 41bd626
> dolphin/src/dolphintabpage.h 95c02ed
> dolphin/src/dolphintabpage.cpp c8e4263
> dolphin/src/dolphintabwidget.h PRE-CREATION
> dolphin/src/dolphintabwidget.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
>
>
> Testing
> -------
>
> Works great so far.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============5755832746424168863==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119115/">https://git.reviewboard.kde.org/r/119115/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119115/diff/2/?file=289539#file289539line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphintabwidget.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">openNewTab</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
we should rename this method to openNewActivatedTab() here and in \
DolphinMainWindow?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">We use this slot for opening new tabs \
with e.g. ctrl + T.</p></pre> </div>
</div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On July 9th, 2014, 10:40 p.m. CEST, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated July 9, 2014, 10:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented DolphinTabWidget class to encapsulate the tab handling from \
DolphinMainWindow.
Removed the method for text squeezing because the QTabBar can do this automatically.
The tab sizes are different, any idea how to fix this?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works great so far.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(7b0210a)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(9c7f185)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(41bd626)</span></li>
<li>dolphin/src/dolphintabpage.h <span style="color: grey">(95c02ed)</span></li>
<li>dolphin/src/dolphintabpage.cpp <span style="color: grey">(c8e4263)</span></li>
<li>dolphin/src/dolphintabwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/dolphintabwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119115/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5755832746424168863==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic