[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 118314: KUrl -> QUrl
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-05-30 17:33:44
Message-ID: 20140530173344.14701.49826 () probe ! kde ! org
[Download RAW message or body]
> On May 26, 2014, 4:02 p.m., Frank Reininghaus wrote:
> > Thanks for the patch. I think that we all agree that we should port away from \
> > kdelibs4support at some point, but is there a reason for doing it right now \
> > (i.e., does it fix a bug or cause some other noticeable improvement)?
> > I'm asking because every large-scale change in the frameworks branch makes \
> > merging master into frameworks more painful. Merging is already non-trivial in \
> > some cases, due to the adjustments that were required to build with Qt5/KF5, and \
> > the replacement of all connect statements with the new syntax (but this at least \
> > fixed a few porting issues that would have been hard to spot otherwise, and which \
> > had to be fixed to make Dolphin work at all).
> > This is just the reason why I proposed in \
> > https://git.reviewboard.kde.org/r/117395/ that only fixes for frameworks-specific \
> > bugs are done in frameworks branch for the time being.
>
> Emmanuel Pescosta wrote:
> > only fixes for frameworks-specific bugs are done in frameworks branch for the \
> > time being.
> Oh sorry, I missed that :(
> Makes sense.
>
> Ok, I'll leave this review request open and when we start with the KF5 port I'll \
> update this patch. Ok?
> Frank Reininghaus wrote:
> Yes, updating it when we stop merging stuff from 4.x to frameworks makes sense! I \
> hope that most of the KUrl -> QUrl transition was done in an automated way anyway, \
> such that it will not be too much work to update it in the future.
> Aleix Pol Gonzalez wrote:
> It's not automatic, the pain you're saving by not merging the patch you'll suffer \
> it by trying to rebase it back.
> Frank Reininghaus wrote:
> OK, so the argument is "the KUrl porting has been done already, so we have to \
> suffer the merging pain, in order to prevent that the KUrl -> QUrl porting has to \
> be done again"? If that is what most people think, feel free to push the patch once \
> all issues are resolved, I don't want to be the one who forces people to throw away \
> useful work.
> I really, really hope that people will start discussing any major changes BEFORE \
> they start working on it at some point, but considering that I repeat this over and \
> over again, and nobody cares, probably this hope is in vain :-(
Coming up with a roadmap could be useful.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118314/#review58494
-----------------------------------------------------------
On May 25, 2014, 1:38 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118314/
> -----------------------------------------------------------
>
> (Updated May 25, 2014, 1:38 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Ported Dolphin from KUrl to QUrl.
>
> Moved the "new name checking" from DolphinView::slotRoleEditingFinished to \
> KFileItemModel::setData, because we need the same url modifying code for both \
> functions - avoid code duplication + porting mistakes.
> RenameDialog:
> Changed renameItems to renameItem, we do the url modifying there for all two cases \
> - avoid code duplication + porting mistakes.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinapplication.cpp 8144da8
> dolphin/src/dolphincontextmenu.h 180f917
> dolphin/src/dolphincontextmenu.cpp 51351f0
> dolphin/src/dolphinmainwindow.h 1192f6e
> dolphin/src/dolphinmainwindow.cpp 049c440
> dolphin/src/dolphinpart.h 9ab1e80
> dolphin/src/dolphinpart.cpp 479b809
> dolphin/src/dolphinpart_ext.h 5272df6
> dolphin/src/dolphinpart_ext.cpp fb7a4d2
> dolphin/src/dolphinviewcontainer.h a7a9969
> dolphin/src/dolphinviewcontainer.cpp 7610625
> dolphin/src/kitemviews/kfileitemmodel.h 62a283d
> dolphin/src/kitemviews/kfileitemmodel.cpp 51bf546
> dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp acb3e0f
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 7a9f31a
> dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp cd448e2
> dolphin/src/kitemviews/private/kfileitemclipboard.h 86eb8e9
> dolphin/src/kitemviews/private/kfileitemclipboard.cpp ebf50e2
> dolphin/src/kitemviews/private/kfileitemmodeldirlister.h da01d20
> dolphin/src/panels/folders/folderspanel.h 14d8e87
> dolphin/src/panels/folders/folderspanel.cpp 0b2ea38
> dolphin/src/panels/folders/treeviewcontextmenu.cpp 2e59ae8
> dolphin/src/panels/information/informationpanel.h c68b66e
> dolphin/src/panels/information/informationpanel.cpp 4ad1276
> dolphin/src/panels/information/informationpanelcontent.h 67fdf6c
> dolphin/src/panels/information/informationpanelcontent.cpp 9dc59db
> dolphin/src/panels/information/phononwidget.h b5aedfe
> dolphin/src/panels/information/phononwidget.cpp 4b2cc28
> dolphin/src/panels/panel.h a0b25d6
> dolphin/src/panels/panel.cpp 14b7c02
> dolphin/src/panels/places/placesitem.h 297f12d
> dolphin/src/panels/places/placesitem.cpp 1729bbd
> dolphin/src/panels/places/placesitemeditdialog.h bf34847
> dolphin/src/panels/places/placesitemeditdialog.cpp 0a66ef7
> dolphin/src/panels/places/placesitemmodel.h 4a374e5
> dolphin/src/panels/places/placesitemmodel.cpp 6ba91c5
> dolphin/src/panels/places/placespanel.h 16112e8
> dolphin/src/panels/places/placespanel.cpp d3614c9
> dolphin/src/panels/terminal/terminalpanel.h 987ee47
> dolphin/src/panels/terminal/terminalpanel.cpp 5c72652
> dolphin/src/search/dolphinsearchbox.h 53b12ff
> dolphin/src/search/dolphinsearchbox.cpp df96f74
> dolphin/src/search/filenamesearchprotocol.h f691f99
> dolphin/src/search/filenamesearchprotocol.cpp b56a995
> dolphin/src/settings/applyviewpropsjob.h 68fdcc4
> dolphin/src/settings/applyviewpropsjob.cpp 9849216
> dolphin/src/settings/dolphinsettingsdialog.h 2de1950
> dolphin/src/settings/dolphinsettingsdialog.cpp 8df2996
> dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0
> dolphin/src/settings/general/behaviorsettingspage.cpp 7633b82
> dolphin/src/settings/general/generalsettingspage.h 0d28664
> dolphin/src/settings/general/generalsettingspage.cpp 8a8adf8
> dolphin/src/settings/startup/startupsettingspage.h 29cdc63
> dolphin/src/settings/startup/startupsettingspage.cpp 7f8c2d5
> dolphin/src/settings/viewpropertiesdialog.cpp 593d1c4
> dolphin/src/settings/viewpropsprogressinfo.h 6f8c763
> dolphin/src/settings/viewpropsprogressinfo.cpp a4a45da
> dolphin/src/statusbar/dolphinstatusbar.h 4d6dbb2
> dolphin/src/statusbar/dolphinstatusbar.cpp 9f17c8e
> dolphin/src/statusbar/spaceinfoobserver.h d2fb6eb
> dolphin/src/statusbar/spaceinfoobserver.cpp 9125a93
> dolphin/src/statusbar/statusbarspaceinfo.h 1065d9f
> dolphin/src/statusbar/statusbarspaceinfo.cpp 3692947
> dolphin/src/tests/kfileitemmodelbenchmark.cpp 66918b6
> dolphin/src/tests/kfileitemmodeltest.cpp 48e72e8
> dolphin/src/tests/testdir.h 0d3c5dd
> dolphin/src/tests/testdir.cpp 8938e60
> dolphin/src/views/dolphinnewfilemenuobserver.h 3b5014a
> dolphin/src/views/dolphinremoteencoding.h b317cc1
> dolphin/src/views/dolphinremoteencoding.cpp bf00e33
> dolphin/src/views/dolphinview.h 4ba1029
> dolphin/src/views/dolphinview.cpp 0e43dcd
> dolphin/src/views/dolphinviewactionhandler.cpp 3955f25
> dolphin/src/views/draganddrophelper.h eda5fc5
> dolphin/src/views/draganddrophelper.cpp f8ae0ad
> dolphin/src/views/renamedialog.h 29ef8bd
> dolphin/src/views/renamedialog.cpp 3b94e01
> dolphin/src/views/versioncontrol/versioncontrolobserver.h 2c07b06
> dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 9033e19
> dolphin/src/views/viewmodecontroller.h f476595
> dolphin/src/views/viewmodecontroller.cpp 26e1818
> dolphin/src/views/viewproperties.h 69b507f
> dolphin/src/views/viewproperties.cpp bcea062
>
> Diff: https://git.reviewboard.kde.org/r/118314/diff/
>
>
> Testing
> -------
>
> KFileItemModelTest fails. (Expanded items)
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118314/">https://git.reviewboard.kde.org/r/118314/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 26th, 2014, 4:02 p.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch. I think that we all agree that we should port away \
from kdelibs4support at some point, but is there a reason for doing it right now \
(i.e., does it fix a bug or cause some other noticeable improvement)?
I'm asking because every large-scale change in the frameworks branch makes \
merging master into frameworks more painful. Merging is already non-trivial in some \
cases, due to the adjustments that were required to build with Qt5/KF5, and the \
replacement of all connect statements with the new syntax (but this at least fixed a \
few porting issues that would have been hard to spot otherwise, and which had to be \
fixed to make Dolphin work at all).
This is just the reason why I proposed in https://git.reviewboard.kde.org/r/117395/ \
that only fixes for frameworks-specific bugs are done in frameworks branch for the \
time being.</pre> </blockquote>
<p>On May 29th, 2014, 1:36 p.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> only fixes for \
frameworks-specific bugs are done in frameworks branch for the time being. Oh sorry, \
I missed that :( Makes sense.
Ok, I'll leave this review request open and when we start with the KF5 port \
I'll update this patch. Ok?</pre> </blockquote>
<p>On May 30th, 2014, 12:53 p.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, updating it when we \
stop merging stuff from 4.x to frameworks makes sense! I hope that most of the KUrl \
-> QUrl transition was done in an automated way anyway, such that it will not be \
too much work to update it in the future.</pre> </blockquote>
<p>On May 30th, 2014, 1:38 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not automatic, \
the pain you're saving by not merging the patch you'll suffer it by trying to \
rebase it back.</pre> </blockquote>
<p>On May 30th, 2014, 1:46 p.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, so the argument is \
"the KUrl porting has been done already, so we have to suffer the merging pain, \
in order to prevent that the KUrl -> QUrl porting has to be done again"? If \
that is what most people think, feel free to push the patch once all issues are \
resolved, I don't want to be the one who forces people to throw away useful work.
I really, really hope that people will start discussing any major changes BEFORE they \
start working on it at some point, but considering that I repeat this over and over \
again, and nobody cares, probably this hope is in vain :-(</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Coming up with a roadmap \
could be useful.</pre> <br />
<p>- Aleix</p>
<br />
<p>On May 25th, 2014, 1:38 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated May 25, 2014, 1:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ported Dolphin from KUrl to QUrl.
Moved the "new name checking" from DolphinView::slotRoleEditingFinished to \
KFileItemModel::setData, because we need the same url modifying code for both \
functions - avoid code duplication + porting mistakes.
RenameDialog:
Changed renameItems to renameItem, we do the url modifying there for all two cases -
avoid code duplication + porting mistakes.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KFileItemModelTest fails. (Expanded items)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinapplication.cpp <span style="color: \
grey">(8144da8)</span></li>
<li>dolphin/src/dolphincontextmenu.h <span style="color: grey">(180f917)</span></li>
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(51351f0)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(1192f6e)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(049c440)</span></li>
<li>dolphin/src/dolphinpart.h <span style="color: grey">(9ab1e80)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(479b809)</span></li>
<li>dolphin/src/dolphinpart_ext.h <span style="color: grey">(5272df6)</span></li>
<li>dolphin/src/dolphinpart_ext.cpp <span style="color: grey">(fb7a4d2)</span></li>
<li>dolphin/src/dolphinviewcontainer.h <span style="color: \
grey">(a7a9969)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(7610625)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: \
grey">(62a283d)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(51bf546)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp <span style="color: \
grey">(acb3e0f)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: \
grey">(7a9f31a)</span></li>
<li>dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp <span style="color: \
grey">(cd448e2)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemclipboard.h <span style="color: \
grey">(86eb8e9)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemclipboard.cpp <span style="color: \
grey">(ebf50e2)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodeldirlister.h <span style="color: \
grey">(da01d20)</span></li>
<li>dolphin/src/panels/folders/folderspanel.h <span style="color: \
grey">(14d8e87)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(0b2ea38)</span></li>
<li>dolphin/src/panels/folders/treeviewcontextmenu.cpp <span style="color: \
grey">(2e59ae8)</span></li>
<li>dolphin/src/panels/information/informationpanel.h <span style="color: \
grey">(c68b66e)</span></li>
<li>dolphin/src/panels/information/informationpanel.cpp <span style="color: \
grey">(4ad1276)</span></li>
<li>dolphin/src/panels/information/informationpanelcontent.h <span style="color: \
grey">(67fdf6c)</span></li>
<li>dolphin/src/panels/information/informationpanelcontent.cpp <span style="color: \
grey">(9dc59db)</span></li>
<li>dolphin/src/panels/information/phononwidget.h <span style="color: \
grey">(b5aedfe)</span></li>
<li>dolphin/src/panels/information/phononwidget.cpp <span style="color: \
grey">(4b2cc28)</span></li>
<li>dolphin/src/panels/panel.h <span style="color: grey">(a0b25d6)</span></li>
<li>dolphin/src/panels/panel.cpp <span style="color: grey">(14b7c02)</span></li>
<li>dolphin/src/panels/places/placesitem.h <span style="color: \
grey">(297f12d)</span></li>
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(1729bbd)</span></li>
<li>dolphin/src/panels/places/placesitemeditdialog.h <span style="color: \
grey">(bf34847)</span></li>
<li>dolphin/src/panels/places/placesitemeditdialog.cpp <span style="color: \
grey">(0a66ef7)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.h <span style="color: \
grey">(4a374e5)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(6ba91c5)</span></li>
<li>dolphin/src/panels/places/placespanel.h <span style="color: \
grey">(16112e8)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(d3614c9)</span></li>
<li>dolphin/src/panels/terminal/terminalpanel.h <span style="color: \
grey">(987ee47)</span></li>
<li>dolphin/src/panels/terminal/terminalpanel.cpp <span style="color: \
grey">(5c72652)</span></li>
<li>dolphin/src/search/dolphinsearchbox.h <span style="color: \
grey">(53b12ff)</span></li>
<li>dolphin/src/search/dolphinsearchbox.cpp <span style="color: \
grey">(df96f74)</span></li>
<li>dolphin/src/search/filenamesearchprotocol.h <span style="color: \
grey">(f691f99)</span></li>
<li>dolphin/src/search/filenamesearchprotocol.cpp <span style="color: \
grey">(b56a995)</span></li>
<li>dolphin/src/settings/applyviewpropsjob.h <span style="color: \
grey">(68fdcc4)</span></li>
<li>dolphin/src/settings/applyviewpropsjob.cpp <span style="color: \
grey">(9849216)</span></li>
<li>dolphin/src/settings/dolphinsettingsdialog.h <span style="color: \
grey">(2de1950)</span></li>
<li>dolphin/src/settings/dolphinsettingsdialog.cpp <span style="color: \
grey">(8df2996)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.h <span style="color: \
grey">(7a9c2f0)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(7633b82)</span></li>
<li>dolphin/src/settings/general/generalsettingspage.h <span style="color: \
grey">(0d28664)</span></li>
<li>dolphin/src/settings/general/generalsettingspage.cpp <span style="color: \
grey">(8a8adf8)</span></li>
<li>dolphin/src/settings/startup/startupsettingspage.h <span style="color: \
grey">(29cdc63)</span></li>
<li>dolphin/src/settings/startup/startupsettingspage.cpp <span style="color: \
grey">(7f8c2d5)</span></li>
<li>dolphin/src/settings/viewpropertiesdialog.cpp <span style="color: \
grey">(593d1c4)</span></li>
<li>dolphin/src/settings/viewpropsprogressinfo.h <span style="color: \
grey">(6f8c763)</span></li>
<li>dolphin/src/settings/viewpropsprogressinfo.cpp <span style="color: \
grey">(a4a45da)</span></li>
<li>dolphin/src/statusbar/dolphinstatusbar.h <span style="color: \
grey">(4d6dbb2)</span></li>
<li>dolphin/src/statusbar/dolphinstatusbar.cpp <span style="color: \
grey">(9f17c8e)</span></li>
<li>dolphin/src/statusbar/spaceinfoobserver.h <span style="color: \
grey">(d2fb6eb)</span></li>
<li>dolphin/src/statusbar/spaceinfoobserver.cpp <span style="color: \
grey">(9125a93)</span></li>
<li>dolphin/src/statusbar/statusbarspaceinfo.h <span style="color: \
grey">(1065d9f)</span></li>
<li>dolphin/src/statusbar/statusbarspaceinfo.cpp <span style="color: \
grey">(3692947)</span></li>
<li>dolphin/src/tests/kfileitemmodelbenchmark.cpp <span style="color: \
grey">(66918b6)</span></li>
<li>dolphin/src/tests/kfileitemmodeltest.cpp <span style="color: \
grey">(48e72e8)</span></li>
<li>dolphin/src/tests/testdir.h <span style="color: grey">(0d3c5dd)</span></li>
<li>dolphin/src/tests/testdir.cpp <span style="color: grey">(8938e60)</span></li>
<li>dolphin/src/views/dolphinnewfilemenuobserver.h <span style="color: \
grey">(3b5014a)</span></li>
<li>dolphin/src/views/dolphinremoteencoding.h <span style="color: \
grey">(b317cc1)</span></li>
<li>dolphin/src/views/dolphinremoteencoding.cpp <span style="color: \
grey">(bf00e33)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(4ba1029)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(0e43dcd)</span></li>
<li>dolphin/src/views/dolphinviewactionhandler.cpp <span style="color: \
grey">(3955f25)</span></li>
<li>dolphin/src/views/draganddrophelper.h <span style="color: \
grey">(eda5fc5)</span></li>
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: \
grey">(f8ae0ad)</span></li>
<li>dolphin/src/views/renamedialog.h <span style="color: grey">(29ef8bd)</span></li>
<li>dolphin/src/views/renamedialog.cpp <span style="color: \
grey">(3b94e01)</span></li>
<li>dolphin/src/views/versioncontrol/versioncontrolobserver.h <span style="color: \
grey">(2c07b06)</span></li>
<li>dolphin/src/views/versioncontrol/versioncontrolobserver.cpp <span style="color: \
grey">(9033e19)</span></li>
<li>dolphin/src/views/viewmodecontroller.h <span style="color: \
grey">(f476595)</span></li>
<li>dolphin/src/views/viewmodecontroller.cpp <span style="color: \
grey">(26e1818)</span></li>
<li>dolphin/src/views/viewproperties.h <span style="color: \
grey">(69b507f)</span></li>
<li>dolphin/src/views/viewproperties.cpp <span style="color: \
grey">(bcea062)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118314/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic