[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 118395: Selection toggle hover effect
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-05-30 13:38:15
Message-ID: 20140530133815.2659.44189 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118395/#review58815
-----------------------------------------------------------
Thanks for the patch.
Maybe I should have tried the last Dolphin 1.x version before I made that remark or \
said "look at Dolphin 1.x before starting to work on this" :-( Sorry that I did not \
do it.
I tried it now, and it turns out that my memory was incorrect: the fading animation \
was not for hovering the toggle itself, but for the appearance of the toggle when \
hovering the corresponding item in the view. The code can be found at
http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=d602600c58754a3211056c2fc95d2c588 \
636c5a3&hb=35e3a9a44a32ccd46a138ee397de405318219803&f=dolphin%2Fsrc%2Fviews%2Fselectiontoggle.cpp
Now I don't really know which of the animations makes more sense, or if they make \
sense at all. I tried your patch, and it works fine, but the change of the selection \
toggle now looks quite subtle. Maybe it's too easy to miss that the toggle is hovered \
now? I really don't know.
Thinking about it again, maybe the animation that fades the selection toggle in when \
hovering the item probably does make some sense. The hover effect of the icon itself \
is animated after all, and now when I hover icons and I focus my attention on the \
toggle, it looks weird that it appears all of a sudden, whereas the effect of the \
icon itself is animated nicely.
But I'm not an expert for these design-related things. If anyone has good arguments \
for or against these animations, please let us know!
- Frank Reininghaus
On May 29, 2014, 1:46 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118395/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 1:46 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Add a fade-in/-out effect to KItemListSelectionToggle as proposed in review request \
> 118320 by Frank.
>
> Diffs
> -----
>
> dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 758dc63
> dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp accbe51
>
> Diff: https://git.reviewboard.kde.org/r/118395/diff/
>
>
> Testing
> -------
>
> Works fine.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118395/">https://git.reviewboard.kde.org/r/118395/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch.
Maybe I should have tried the last Dolphin 1.x version before I made that remark or \
said "look at Dolphin 1.x before starting to work on this" :-( Sorry that I \
did not do it.
I tried it now, and it turns out that my memory was incorrect: the fading animation \
was not for hovering the toggle itself, but for the appearance of the toggle when \
hovering the corresponding item in the view. The code can be found at
http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=d602600c58754a3211056c2fc \
95d2c588636c5a3&hb=35e3a9a44a32ccd46a138ee397de405318219803&f=dolphin%2Fsrc%2Fviews%2Fselectiontoggle.cpp
Now I don't really know which of the animations makes more sense, or if they make \
sense at all. I tried your patch, and it works fine, but the change of the selection \
toggle now looks quite subtle. Maybe it's too easy to miss that the toggle is \
hovered now? I really don't know.
Thinking about it again, maybe the animation that fades the selection toggle in when \
hovering the item probably does make some sense. The hover effect of the icon itself \
is animated after all, and now when I hover icons and I focus my attention on the \
toggle, it looks weird that it appears all of a sudden, whereas the effect of the \
icon itself is animated nicely.
But I'm not an expert for these design-related things. If anyone has good \
arguments for or against these animations, please let us know!</pre> <br />
<p>- Frank Reininghaus</p>
<br />
<p>On May 29th, 2014, 1:46 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated May 29, 2014, 1:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a fade-in/-out effect to KItemListSelectionToggle as proposed in \
review request 118320 by Frank.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/kitemlistselectiontoggle.h <span style="color: \
grey">(758dc63)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp <span style="color: \
grey">(accbe51)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118395/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic