[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 117478: Convert dolphin (frameworks) to Qt5 signal/slot syntax
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-04-10 21:32:55
Message-ID: 20140410213255.5498.1345 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117478/#review55417
-----------------------------------------------------------
dolphin/src/views/tooltips/filemetadatatooltip.cpp
<https://git.reviewboard.kde.org/r/117478/#comment38581>
Compiling error
Please move this connect into #ifndef HAVE_BALOO check above.
We need one connect statement with \
Baloo::FileMetaDataWidget::metaDataRequestFinished in #else and one with \
KFileMetaDataWidget::metaDataRequestFinished in #ifndef HAVE_BALOO
- Emmanuel Pescosta
On April 10, 2014, 4:57 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117478/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 4:57 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Requires https://git.reviewboard.kde.org/r/117395/
>
> Most of this conversion was done automatically, only minor manual changes were \
> needed. There is a problem with KAction -> QAction, since there is no longer the \
> signal triggered() that reports the middle mouse button. I attempted to fix this by \
> using QApplication::mouseButtons(), however the triggered signal is emitted after \
> the mouse is released, so we don't get that reported anymore. Will have to \
> investigate more how this can be fixed. This issue affects middle mouse clicking on \
> any toolbar button. Other than that dolphin seems to work fine.
> The terminal view signals could not be converted since there is no header file \
> available that defines that signal (-> cannot get the function pointer).
>
> Diffs
> -----
>
> dolphin/src/dolphincontextmenu.cpp f295de7
> dolphin/src/dolphinmainwindow.h cb97612
> dolphin/src/dolphinmainwindow.cpp 8473014
> dolphin/src/dolphinpart.cpp 9081731
> dolphin/src/dolphinremoveaction.cpp 7d7c2f0
> dolphin/src/dolphinviewcontainer.cpp 768fd5e
> dolphin/src/filterbar/filterbar.cpp 6de6fbe
> dolphin/src/kitemviews/kfileitemlistview.cpp fd01f2c
> dolphin/src/kitemviews/kfileitemmodel.cpp fd773e1
> dolphin/src/kitemviews/kfileitemmodelrolesupdater.h a9e979a
> dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40
> dolphin/src/kitemviews/kitemlistcontainer.cpp 8498286
> dolphin/src/kitemviews/kitemlistcontroller.cpp 7344b99
> dolphin/src/kitemviews/kitemlistheader.cpp e89ece0
> dolphin/src/kitemviews/kitemlistview.cpp 82f8a20
> dolphin/src/kitemviews/kitemlistwidget.cpp 85cd70c
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9a9a734
> dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp 65afb7c
> dolphin/src/kitemviews/private/kfileitemclipboard.cpp faace2a
> dolphin/src/kitemviews/private/kitemlistheaderwidget.cpp 1f210ab
> dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 0a48f1b
> dolphin/src/kitemviews/private/kitemlistsmoothscroller.cpp 491461b
> dolphin/src/kitemviews/private/kitemlistviewanimation.cpp e347c5b
> dolphin/src/panels/folders/folderspanel.cpp 46c1b34
> dolphin/src/panels/folders/treeviewcontextmenu.cpp fa8844d
> dolphin/src/panels/information/informationpanel.cpp eda74f3
> dolphin/src/panels/information/informationpanelcontent.cpp b2dd158
> dolphin/src/panels/information/phononwidget.cpp a36ada1
> dolphin/src/panels/information/pixmapviewer.cpp 8a752c5
> dolphin/src/panels/places/placesitem.cpp 41f22cc
> dolphin/src/panels/places/placesitemeditdialog.cpp 08c910d
> dolphin/src/panels/places/placesitemmodel.cpp baa770d
> dolphin/src/panels/places/placespanel.cpp d5308ea
> dolphin/src/panels/terminal/terminalpanel.cpp bfd3002
> dolphin/src/search/dolphinfacetswidget.cpp b7315a0
> dolphin/src/search/dolphinsearchbox.cpp c178c43
> dolphin/src/search/filenamesearchprotocol.cpp 4d6f59f
> dolphin/src/settings/additionalinfodialog.cpp e9d5f60
> dolphin/src/settings/applyviewpropsjob.cpp 4bc77ca
> dolphin/src/settings/dolphinsettingsdialog.cpp 609e2ab
> dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d
> dolphin/src/settings/general/configurepreviewplugindialog.cpp 3ca08df
> dolphin/src/settings/general/confirmationssettingspage.cpp ab23a19
> dolphin/src/settings/general/generalsettingspage.cpp 18e1528
> dolphin/src/settings/general/previewssettingspage.cpp 38b61b9
> dolphin/src/settings/general/statusbarsettingspage.cpp 48622ac
> dolphin/src/settings/kcm/kcmdolphingeneral.cpp 26cb580
> dolphin/src/settings/kcm/kcmdolphinnavigation.cpp 36345a5
> dolphin/src/settings/kcm/kcmdolphinservices.cpp 6d8c761
> dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp a7a9db3
> dolphin/src/settings/navigation/navigationsettingspage.cpp 8076d70
> dolphin/src/settings/serviceitemdelegate.cpp 7538e03
> dolphin/src/settings/services/servicessettingspage.cpp 48e816b
> dolphin/src/settings/startup/startupsettingspage.cpp 6938263
> dolphin/src/settings/trash/trashsettingspage.cpp cd69985
> dolphin/src/settings/viewmodes/dolphinfontrequester.cpp 6cb7b99
> dolphin/src/settings/viewmodes/viewsettingspage.cpp 4f8a3f0
> dolphin/src/settings/viewmodes/viewsettingstab.cpp bc12451
> dolphin/src/settings/viewpropertiesdialog.cpp 574f8e1
> dolphin/src/settings/viewpropsprogressinfo.cpp 9b7797d
> dolphin/src/statusbar/dolphinstatusbar.cpp 671ef4f
> dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833
> dolphin/src/views/dolphinnewfilemenuobserver.h 239476e
> dolphin/src/views/dolphinnewfilemenuobserver.cpp 7669f15
> dolphin/src/views/dolphinremoteencoding.cpp 04b350e
> dolphin/src/views/dolphinview.cpp 9f5f48a
> dolphin/src/views/dolphinviewactionhandler.h e80ffc0
> dolphin/src/views/dolphinviewactionhandler.cpp 48ec95c
> dolphin/src/views/renamedialog.cpp d8dbd77
> dolphin/src/views/tooltips/filemetadatatooltip.cpp b726996
> dolphin/src/views/tooltips/tooltipmanager.cpp bd69483
> dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 36345d9
>
> Diff: https://git.reviewboard.kde.org/r/117478/diff/
>
>
> Testing
> -------
>
> After converting all the signal/slot connections, dolphin seems to work normally.
>
> I got a crash when moving something to trash, but I think this is because I \
> currently don't have kio-trash on my system.
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117478/">https://git.reviewboard.kde.org/r/117478/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117478/diff/3/?file=264446#file264446line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/views/tooltips/filemetadatatooltip.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">FileMetaDataToolTip::FileMetaDataToolTip(QWidget* parent) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span><span \
class="n">m_fileMetaDataWidget</span><span class="p">,</span> <span class="n"><span \
class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span \
class="n">metaDataRequestFinished</span><span class="p"><span \
class="hl">(</span></span><span class="n"><span \
class="hl">KFileItemList</span></span><span class="p"><span \
class="hl">))</span>,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_fileMetaDataWidget</span><span class="p">,</span> \
<span class="o"><span class="hl">&</span></span><span class="n"><span \
class="hl">KFileMetaDataWidget</span></span><span class="o"><span \
class="hl">::</span></span><span class="n">metaDataRequestFinished</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiling \
error
Please move this connect into #ifndef HAVE_BALOO check above.
We need one connect statement with Baloo::FileMetaDataWidget::metaDataRequestFinished \
in #else and one with KFileMetaDataWidget::metaDataRequestFinished in #ifndef \
HAVE_BALOO</pre> </div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On April 10th, 2014, 4:57 p.m. CEST, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated April 10, 2014, 4:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Requires https://git.reviewboard.kde.org/r/117395/
Most of this conversion was done automatically, only minor manual changes were \
needed. There is a problem with KAction -> QAction, since there is no longer the \
signal triggered() that reports the middle mouse button. I attempted to fix this by \
using QApplication::mouseButtons(), however the triggered signal is emitted after the \
mouse is released, so we don't get that reported anymore. Will have to \
investigate more how this can be fixed. This issue affects middle mouse clicking on \
any toolbar button. Other than that dolphin seems to work fine.
The terminal view signals could not be converted since there is no header file \
available that defines that signal (-> cannot get the function pointer).</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After converting all the signal/slot connections, dolphin seems to work \
normally.
I got a crash when moving something to trash, but I think this is because I currently \
don't have kio-trash on my system.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(f295de7)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(cb97612)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(8473014)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(9081731)</span></li>
<li>dolphin/src/dolphinremoveaction.cpp <span style="color: \
grey">(7d7c2f0)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(768fd5e)</span></li>
<li>dolphin/src/filterbar/filterbar.cpp <span style="color: \
grey">(6de6fbe)</span></li>
<li>dolphin/src/kitemviews/kfileitemlistview.cpp <span style="color: \
grey">(fd01f2c)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(fd773e1)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodelrolesupdater.h <span style="color: \
grey">(a9e979a)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp <span style="color: \
grey">(0865d40)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontainer.cpp <span style="color: \
grey">(8498286)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(7344b99)</span></li>
<li>dolphin/src/kitemviews/kitemlistheader.cpp <span style="color: \
grey">(e89ece0)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.cpp <span style="color: \
grey">(82f8a20)</span></li>
<li>dolphin/src/kitemviews/kitemlistwidget.cpp <span style="color: \
grey">(85cd70c)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: \
grey">(9a9a734)</span></li>
<li>dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp <span style="color: \
grey">(65afb7c)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemclipboard.cpp <span style="color: \
grey">(faace2a)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistheaderwidget.cpp <span style="color: \
grey">(1f210ab)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistroleeditor.cpp <span style="color: \
grey">(0a48f1b)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistsmoothscroller.cpp <span style="color: \
grey">(491461b)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistviewanimation.cpp <span style="color: \
grey">(e347c5b)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(46c1b34)</span></li>
<li>dolphin/src/panels/folders/treeviewcontextmenu.cpp <span style="color: \
grey">(fa8844d)</span></li>
<li>dolphin/src/panels/information/informationpanel.cpp <span style="color: \
grey">(eda74f3)</span></li>
<li>dolphin/src/panels/information/informationpanelcontent.cpp <span style="color: \
grey">(b2dd158)</span></li>
<li>dolphin/src/panels/information/phononwidget.cpp <span style="color: \
grey">(a36ada1)</span></li>
<li>dolphin/src/panels/information/pixmapviewer.cpp <span style="color: \
grey">(8a752c5)</span></li>
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(41f22cc)</span></li>
<li>dolphin/src/panels/places/placesitemeditdialog.cpp <span style="color: \
grey">(08c910d)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(baa770d)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(d5308ea)</span></li>
<li>dolphin/src/panels/terminal/terminalpanel.cpp <span style="color: \
grey">(bfd3002)</span></li>
<li>dolphin/src/search/dolphinfacetswidget.cpp <span style="color: \
grey">(b7315a0)</span></li>
<li>dolphin/src/search/dolphinsearchbox.cpp <span style="color: \
grey">(c178c43)</span></li>
<li>dolphin/src/search/filenamesearchprotocol.cpp <span style="color: \
grey">(4d6f59f)</span></li>
<li>dolphin/src/settings/additionalinfodialog.cpp <span style="color: \
grey">(e9d5f60)</span></li>
<li>dolphin/src/settings/applyviewpropsjob.cpp <span style="color: \
grey">(4bc77ca)</span></li>
<li>dolphin/src/settings/dolphinsettingsdialog.cpp <span style="color: \
grey">(609e2ab)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(cbbde1d)</span></li>
<li>dolphin/src/settings/general/configurepreviewplugindialog.cpp <span \
style="color: grey">(3ca08df)</span></li>
<li>dolphin/src/settings/general/confirmationssettingspage.cpp <span style="color: \
grey">(ab23a19)</span></li>
<li>dolphin/src/settings/general/generalsettingspage.cpp <span style="color: \
grey">(18e1528)</span></li>
<li>dolphin/src/settings/general/previewssettingspage.cpp <span style="color: \
grey">(38b61b9)</span></li>
<li>dolphin/src/settings/general/statusbarsettingspage.cpp <span style="color: \
grey">(48622ac)</span></li>
<li>dolphin/src/settings/kcm/kcmdolphingeneral.cpp <span style="color: \
grey">(26cb580)</span></li>
<li>dolphin/src/settings/kcm/kcmdolphinnavigation.cpp <span style="color: \
grey">(36345a5)</span></li>
<li>dolphin/src/settings/kcm/kcmdolphinservices.cpp <span style="color: \
grey">(6d8c761)</span></li>
<li>dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp <span style="color: \
grey">(a7a9db3)</span></li>
<li>dolphin/src/settings/navigation/navigationsettingspage.cpp <span style="color: \
grey">(8076d70)</span></li>
<li>dolphin/src/settings/serviceitemdelegate.cpp <span style="color: \
grey">(7538e03)</span></li>
<li>dolphin/src/settings/services/servicessettingspage.cpp <span style="color: \
grey">(48e816b)</span></li>
<li>dolphin/src/settings/startup/startupsettingspage.cpp <span style="color: \
grey">(6938263)</span></li>
<li>dolphin/src/settings/trash/trashsettingspage.cpp <span style="color: \
grey">(cd69985)</span></li>
<li>dolphin/src/settings/viewmodes/dolphinfontrequester.cpp <span style="color: \
grey">(6cb7b99)</span></li>
<li>dolphin/src/settings/viewmodes/viewsettingspage.cpp <span style="color: \
grey">(4f8a3f0)</span></li>
<li>dolphin/src/settings/viewmodes/viewsettingstab.cpp <span style="color: \
grey">(bc12451)</span></li>
<li>dolphin/src/settings/viewpropertiesdialog.cpp <span style="color: \
grey">(574f8e1)</span></li>
<li>dolphin/src/settings/viewpropsprogressinfo.cpp <span style="color: \
grey">(9b7797d)</span></li>
<li>dolphin/src/statusbar/dolphinstatusbar.cpp <span style="color: \
grey">(671ef4f)</span></li>
<li>dolphin/src/statusbar/statusbarspaceinfo.cpp <span style="color: \
grey">(61b2833)</span></li>
<li>dolphin/src/views/dolphinnewfilemenuobserver.h <span style="color: \
grey">(239476e)</span></li>
<li>dolphin/src/views/dolphinnewfilemenuobserver.cpp <span style="color: \
grey">(7669f15)</span></li>
<li>dolphin/src/views/dolphinremoteencoding.cpp <span style="color: \
grey">(04b350e)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(9f5f48a)</span></li>
<li>dolphin/src/views/dolphinviewactionhandler.h <span style="color: \
grey">(e80ffc0)</span></li>
<li>dolphin/src/views/dolphinviewactionhandler.cpp <span style="color: \
grey">(48ec95c)</span></li>
<li>dolphin/src/views/renamedialog.cpp <span style="color: \
grey">(d8dbd77)</span></li>
<li>dolphin/src/views/tooltips/filemetadatatooltip.cpp <span style="color: \
grey">(b726996)</span></li>
<li>dolphin/src/views/tooltips/tooltipmanager.cpp <span style="color: \
grey">(bd69483)</span></li>
<li>dolphin/src/views/versioncontrol/versioncontrolobserver.cpp <span style="color: \
grey">(36345d9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117478/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic