[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 114614: Make the drag and drop error/info message handling a little bit better/mo
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-04-04 13:16:55
Message-ID: 20140404131655.1245.78014 () probe ! kde ! org
[Download RAW message or body]
> On Dec. 28, 2013, 2:59 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! In principle, the idea to use a singleton to \
> > handle all drag&drop-related messages is good. However, if we had more \
> > than one DolphinMainWindow per process, it would cause each message to \
> > be shown in all windows, right?
> > Dolphin did use a single process for all windows before KDE SC 4.7. \
> > That was changed because Strigi caused Dolphin to crash a lot at that \
> > time, and it was quite annoying to see all Dolphin windows disappear if \
> > one of them crashed. Moreover, the application-modal KIO dialogs caused \
> > all Dolphin windows to freeze if a dialog was shown for one of them. \
> > There were some discussions about this issue recently, see, e.g.,
> > http://lists.kde.org/?t=137537235900004&r=1&w=2
> >
> > Dolphin is much more stable now than it used to be, and the KIO dialogs \
> > are now window-modal thanks to Dawit's efforts:
> > https://git.reviewboard.kde.org/r/114473/
> > https://git.reviewboard.kde.org/r/114436/
> >
> > Therefore, we could actually make Dolphin a KUniqueApplication again in \
> > 4.13. One of the benefits would be that opening a new Dolphin window \
> > would be very fast if the 'dolphin' process is running already. It \
> > might not be quite as easy as reverting
> > http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=fff7573ebb910712ad97951bf1762e6a7bb0bdc7
> >
> > though because some of the affected code might have changed in the mean \
> > time.
>
> Emmanuel Pescosta wrote:
> What if we show the error messages from Drag and Drop handler, \
> new-file-menu observer, ... always in the active Dolphin window only?
> If so, we need a "proxy" object which delegates the messages to the \
> active window.
Any updates on making Dolphin a KUniqueApplication again?
According to KF5 API docs, KUniqueApplication is only kde4support.
http://api.kde.org/frameworks-api/frameworks5-apidocs/kde4support/html/classKUniqueApplication.html
Should we really rely on it in the 4.x era, given that KF5 is almost ready \
to start the porting to KF5/Qt5?
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114614/#review46282
-----------------------------------------------------------
On Dec. 22, 2013, 4:55 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114614/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2013, 4:55 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 294054
> http://bugs.kde.org/show_bug.cgi?id=294054
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Error messages like "Folder is not writealbe" are shown in a red message \
> box. Info messages like "Folder cannot be dropped on itself" are shown in \
> the status bar.
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 6b046c2
> dolphin/src/dolphinmainwindow.cpp a4dbb6f
> dolphin/src/dolphinpart.cpp 9081731
> dolphin/src/dolphinviewcontainer.cpp cc26198
> dolphin/src/panels/folders/folderspanel.h 14d8e87
> dolphin/src/panels/folders/folderspanel.cpp 46c1b34
> dolphin/src/panels/places/placespanel.cpp d5308ea
> dolphin/src/views/dolphinview.cpp 1416bb6
> dolphin/src/views/draganddrophelper.h eda5fc5
> dolphin/src/views/draganddrophelper.cpp f8ae0ad
>
> Diff: https://git.reviewboard.kde.org/r/114614/diff/
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114614/">https://git.reviewboard.kde.org/r/114614/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On December 28th, 2013, \
2:59 p.m. CET, <b>Frank Reininghaus</b> wrote:</p> <blockquote \
style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch! In principle, the idea to use a \
singleton to handle all drag&drop-related messages is good. However, if \
we had more than one DolphinMainWindow per process, it would cause each \
message to be shown in all windows, right?
Dolphin did use a single process for all windows before KDE SC 4.7. That \
was changed because Strigi caused Dolphin to crash a lot at that time, and \
it was quite annoying to see all Dolphin windows disappear if one of them \
crashed. Moreover, the application-modal KIO dialogs caused all Dolphin \
windows to freeze if a dialog was shown for one of them. There were some \
discussions about this issue recently, see, e.g.,
http://lists.kde.org/?t=137537235900004&r=1&w=2
Dolphin is much more stable now than it used to be, and the KIO dialogs are \
now window-modal thanks to Dawit's efforts:
https://git.reviewboard.kde.org/r/114473/
https://git.reviewboard.kde.org/r/114436/
Therefore, we could actually make Dolphin a KUniqueApplication again in \
4.13. One of the benefits would be that opening a new Dolphin window would \
be very fast if the 'dolphin' process is running already. It might \
not be quite as easy as reverting
http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=fff7573ebb910712ad97951bf1762e6a7bb0bdc7
though because some of the affected code might have changed in the mean \
time.</pre> </blockquote>
<p>On February 8th, 2014, 8 p.m. CET, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What if we show the error messages from Drag and Drop handler, \
new-file-menu observer, ... always in the active Dolphin window only?
If so, we need a "proxy" object which delegates the messages to \
the active window.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any updates on \
making Dolphin a KUniqueApplication again?
According to KF5 API docs, KUniqueApplication is only kde4support.
http://api.kde.org/frameworks-api/frameworks5-apidocs/kde4support/html/classKUniqueApplication.html
Should we really rely on it in the 4.x era, given that KF5 is almost ready \
to start the porting to KF5/Qt5? </pre> <br />
<p>- Emmanuel</p>
<br />
<p>On December 22nd, 2013, 4:55 p.m. CET, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2013, 4:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=294054">294054</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Error messages like "Folder is not writealbe" are \
shown in a red message box. Info messages like "Folder cannot be \
dropped on itself" are shown in the status bar.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: \
grey">(6b046c2)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(a4dbb6f)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: \
grey">(9081731)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(cc26198)</span></li>
<li>dolphin/src/panels/folders/folderspanel.h <span style="color: \
grey">(14d8e87)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(46c1b34)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(d5308ea)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(1416bb6)</span></li>
<li>dolphin/src/views/draganddrophelper.h <span style="color: \
grey">(eda5fc5)</span></li>
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: \
grey">(f8ae0ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114614/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic