[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Dolphin and Baloo
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2014-02-06 16:18:34
Message-ID: CAH3KK-WgkoBAtDcHJXZ4GwRjuYOSOYMmJhbNg9jjm3WKQJ6u1Q () mail ! gmail ! com
[Download RAW message or body]
Really small coding-style issue: dolphinsearchbox.cpp line 443 and 444
should be "} else {"
feature/baloo looks good!
+1 for merge
Thanks for this great work :)
Btw.:
Can Baloo extract query terms, search text, rating, ... from a search url?
I need this to fix https://git.reviewboard.kde.org/r/111968 properly.
2014-02-06 15:34 GMT+01:00 Vishesh Handa <me@vhanda.in>:
> On Thursday 06 February 2014 14:37:49 Frank Reininghaus wrote:
> > Hi,
> >
> > the build is broken again. Attached patch fixes it for me (I haven't
> > tested it with Baloo installed yet though).
> >
> > 2014-02-06 10:41 GMT+01:00 Vishesh Handa:
> > > On Thursday 06 February 2014 09:34:59 Frank Reininghaus wrote:
> > >> Hi,
> > >>
> > >> 2014-02-05 Christoph Feck:
> > >> > Hi,
> > >> >
> > >> > It would be nice to have these changes merged in the next two weeks
> > >> > (i.e. one week before the freeze, see
> > >> > http://techbase.kde.org/Schedules/KDE4/4.13_Release_Schedule )
> > >>
> > >> that's fine. From my point of view, the Baloo code is basically ready
> > >> (once the foreach loop is re-added to prevent that 322348 comes back).
> > >
> > > Fixed
> > >
> > >> I'll try to have another look at the code later, and I also encourage
> > >> others to do so. If nothing else comes up today, I'd say that the
> > >> branch can be merged (if Vishesh thinks that the commit history of
> > >> that branch is worth keeping) or alternatively, master can be merged
> > >> into feature/baloo and then the diff be applied to master as a single
> > >> commit.
> > >
> > > Lets keep the history.
> >
> > Just out of curiosity, may I ask why the history is important? The
> > reason I'm asking is that I often use "git log" and "git blame" to
> > find out when and why some code was changed, and to understand why the
> > code is as it is (often very useful when I find out which line causes
> > a bug and I'm wondering why the line is there at all). This technique
> > is obviously much less useful if some lines/files get changed very
> > often.
> >
> > If the branch contained a sequence of commits with valid intermediate
> > states which could help to find the cause of regressions in the
> > future, or which could help to understand the structure of the new
> > code, I could see that keeping all those commits makes sense. However,
> > from my point of view, most of the commits will just add noise to the
> > output of "git log" and "git blame" and make finding out about the
> > origin of some lines quite painful.
> >
> > But I don't want to start bikeshedding about this issue - if you can
> > tell any reason why the history will be useful to you in the future,
> > I'll shut up ;-)
> >
>
> Nah. It's cool. No history it is.
>
> I'll push the changes later today.
>
> --
> Vishesh Handa
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div>Really small coding-style issue: dolphinsearchbox.cpp line \
443 and 444 should be "} else {"<br><br>feature/baloo looks good! \
<br></div>+1 for merge<br><br></div><div>Thanks for this great work :)<br> \
<br></div><div>Btw.:<br></div><div>Can Baloo extract query terms, search text, \
rating, ... from a search url?<br></div><div>I need this to fix <a \
href="https://git.reviewboard.kde.org/r/111968">https://git.reviewboard.kde.org/r/111968</a> \
properly.<br> </div></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">2014-02-06 15:34 GMT+01:00 Vishesh Handa <span dir="ltr"><<a \
href="mailto:me@vhanda.in" \
target="_blank">me@vhanda.in</a>></span>:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
class="HOEnZb"><div class="h5">On Thursday 06 February 2014 14:37:49 Frank \
Reininghaus wrote:<br> > Hi,<br>
><br>
> the build is broken again. Attached patch fixes it for me (I haven't<br>
> tested it with Baloo installed yet though).<br>
><br>
> 2014-02-06 10:41 GMT+01:00 Vishesh Handa:<br>
> > On Thursday 06 February 2014 09:34:59 Frank Reininghaus wrote:<br>
> >> Hi,<br>
> >><br>
> >> 2014-02-05 Christoph Feck:<br>
> >> > Hi,<br>
> >> ><br>
> >> > It would be nice to have these changes merged in the next two \
weeks<br> > >> > (i.e. one week before the freeze, see<br>
> >> > <a \
href="http://techbase.kde.org/Schedules/KDE4/4.13_Release_Schedule" \
target="_blank">http://techbase.kde.org/Schedules/KDE4/4.13_Release_Schedule</a> \
)<br> > >><br>
> >> that's fine. From my point of view, the Baloo code is basically \
ready<br> > >> (once the foreach loop is re-added to prevent that 322348 \
comes back).<br> > ><br>
> > Fixed<br>
> ><br>
> >> I'll try to have another look at the code later, and I also \
encourage<br> > >> others to do so. If nothing else comes up today, I'd \
say that the<br> > >> branch can be merged (if Vishesh thinks that the \
commit history of<br> > >> that branch is worth keeping) or alternatively, \
master can be merged<br> > >> into feature/baloo and then the diff be \
applied to master as a single<br> > >> commit.<br>
> ><br>
> > Lets keep the history.<br>
><br>
> Just out of curiosity, may I ask why the history is important? The<br>
> reason I'm asking is that I often use "git log" and "git \
blame" to<br> > find out when and why some code was changed, and to \
understand why the<br> > code is as it is (often very useful when I find out which \
line causes<br> > a bug and I'm wondering why the line is there at all). This \
technique<br> > is obviously much less useful if some lines/files get changed \
very<br> > often.<br>
><br>
> If the branch contained a sequence of commits with valid intermediate<br>
> states which could help to find the cause of regressions in the<br>
> future, or which could help to understand the structure of the new<br>
> code, I could see that keeping all those commits makes sense. However,<br>
> from my point of view, most of the commits will just add noise to the<br>
> output of "git log" and "git blame" and make finding out \
about the<br> > origin of some lines quite painful.<br>
><br>
> But I don't want to start bikeshedding about this issue - if you can<br>
> tell any reason why the history will be useful to you in the future,<br>
> I'll shut up ;-)<br>
><br>
<br>
</div></div>Nah. It's cool. No history it is.<br>
<br>
I'll push the changes later today.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Vishesh Handa<br>
</font></span></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic