This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114812/ |
On February 3rd, 2014, 10:31 a.m. UTC, Phil Schaf wrote:
a question: does this fix this? https://bugs.kde.org/show_bug.cgi?id=264717 i.e. work with symlinks to the dropbox directory?On February 3rd, 2014, 12:53 p.m. UTC, Emmanuel Pescosta wrote:
> does this fix this? No, this problem is (nearly) unsolvable within this plugin or within Dolphin - it can be fixed with some really (!!!) ugly hacks, but this will drastically slow down this plugin. This needs adjustments in the Dropbox client itself. It would be much better if Dropbox does smth. like git or svn for example, so that you can put every folder under version control + symlinks will also work ;)
> No, this problem is (nearly) unsolvable within this plugin or within Dolphin actually, you just have to save the real dropbox path once (say /mnt/somedisk/Dropbox), and then when querying some path, check if there’s a symlink in the path’s parents to the real dropbox path or one of its parents. (e.g. if you’re in ~/Dropbox/foobar/, you check all path components from ~/Dropbox/foobar/ up, and find that ~/Dropbox is a symlink to /mnt/somedisk/Dropbox). then you append the part of the symlink to the real dropbox path (e.g. pathjoin(/mnt/Dropbox, foobar/)) and you’re done. that just requires to check each path component above the directory you’re checking the status of once with .isSymLink(). neglegible. (of course you only have to check directories, not files) seriously, the plugin is unusable without that functionality once you have /home/ on a SSD and dropbox somewhere else because don’t want it creating heaps of IO, and the functionality isn’t IO intensive or computationally expensive at all.
- Phil
On January 30th, 2014, 12:11 p.m. UTC, Emmanuel Pescosta wrote:
Review request for Dolphin.
By Emmanuel Pescosta.
Updated Jan. 30, 2014, 12:11 p.m.
Bugs:
298199
Repository:
dolphin-plugins
Description
Testing
Diffs
|